kernel: smp: CPU start may result in null pointer access #68388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is observed that starting up CPU may result in other CPUs crashing due to de-referencing NULL pointers. Note that this happened on the up_squared board, but there was no way to attach debugger to verify. It started working again after moving z_dummy_thread_init() before smp_timer_init(), which was the old behavior before commit eefaeee where the issue first appeared. So mimic the old behavior to workaround the issue. Fixes zephyrproject-rtos#68115 Signed-off-by: Daniel Leung <daniel.leung@intel.com>
zephyrbot
requested review from
andyross,
ceolin,
cfriedt,
nashif,
npitre and
peter-mitsis
andyross
approved these changes
Feb 1, 2024
npitre
approved these changes
Feb 1, 2024
jhedberg
approved these changes
Feb 1, 2024
nashif
approved these changes
Feb 1, 2024
My guess is that this is due to the current thread pointer being NULL at boot, and it is set at the end of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is observed that starting up CPU may result in other CPUs crashing due to de-referencing NULL pointers. Note that this happened on the up_squared board, but there was no way to attach debugger to verify. It started working again after moving z_dummy_thread_init() before smp_timer_init(), which was the old behavior before commit
eefaeee where the issue first appeared. So mimic the old behavior to workaround the issue.
Fixes #68115