Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: gptp: Use local port identity when forwarding sync messages #68387

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

mschappa
Copy link
Contributor

As defined in IEEE802.1AS-2020 ch. 10.2.12.2.1, the port identity of an MDSyncSend structure sent from a port shall be set to the port identity of the sending port according to and ch. 8.5.2.

This commit replaces the port identity before forwarding a sync.

Fixes #68385

Copy link
Member

@jukkar jukkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nit about the typo in the comment

subsys/net/l2/ethernet/gptp/gptp_mi.c Outdated Show resolved Hide resolved
@jukkar jukkar requested a review from rlubos February 1, 2024 07:05
As defined in IEEE802.1AS-2020 ch. 10.2.12.2.1, the port identity
of an MDSyncSend structure sent from a port shall be set to the
port identity of the sending port according to and ch. 8.5.2.

This commit replaces the port identity before forwarding a sync.

Fixes zephyrproject-rtos#68385

Signed-off-by: Manuel Schappacher <manuel.schappacher@hs-offenburg.de>
@henrikbrixandersen henrikbrixandersen merged commit b5bf5a3 into zephyrproject-rtos:main Feb 2, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong port indentity when forwarding sync messages
5 participants