drivers: display: fix ili9xxx write size #68378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify write size used by mipi_write_display, so that implementers of MIPI drivers know to use the buf_size field of the display buffer descriptor to determine write size. Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>
Fix usage of MIPI buffer descriptor in ili9xxx driver. Previously, the buffer descriptor size was being set to display buffer size. For cases where the write height/width was not equal to the size of the buffer, this resulted in additional data being written that was not needed. To resolve this, calculate the mipi descriptor buffer size in the driver Also, remove the unconditional setting of mipi_desc.height, as this would override the previous (correct) setting. Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>
Check the return code of mipi_dbi_reset, and do not delay for the reset wait time unless the mipi controller has issued a hardware reset to the display. Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>
decsny
approved these changes
Jan 31, 2024
henrikbrixandersen
approved these changes
Feb 1, 2024
jfischer-no
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue I noticed when performing additional testing of #64587, which does not break the display driver but can result in longer write times for the ILI9xxx display when using display buffer descriptors with a
buf_sizenot equal to the requested write area. The MIPI DBI driver bases the amount of data to write on thebuf_sizefield of the display buffer descriptor, so if this is not equal to thedesc->height * desc->width * diplay_bytes_per_pixelmore data will be written then strictly necessary.