Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: build: parse_syscalls: Add exception handling #68371

Closed
wants to merge 1 commit into from
Closed

scripts: build: parse_syscalls: Add exception handling #68371

wants to merge 1 commit into from

Conversation

Bazifrasool
Copy link

@Bazifrasool Bazifrasool commented Jan 31, 2024

Adds exception handling to analyze_headers in parse_syscalls.py

  • In case a header file contains a non utf-8 character, decode fails
  • Add exception handling to inform at compile time which header file failed, so it can be resolved

Copy link

Hello @Bazifrasool, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@Bazifrasool Bazifrasool changed the title [FIX] Add exception handling to analyze_headers function scripts: build: parse_syscalls: Add exception handling Jan 31, 2024
Copy link
Collaborator

@tejlmand tejlmand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your commits and remove the merge commit so that there is only a single commit in this PR.

You may read more in the contribution guideline:
https://docs.zephyrproject.org/latest/contribute/guidelines.html#contribution-workflow

scripts/build/parse_syscalls.py Outdated Show resolved Hide resolved
In case a header file contains a non utf-8 character, decode fails
Add exception handling to inform at compile time which header file failed, so it can be resolved

Signed-off-by: Bazif Rasool <baziflaherwal@gmail.com>
@Bazifrasool
Copy link
Author

@tejlmand squashed the commits and adopted sys.stderr.write()

@Bazifrasool Bazifrasool deleted the read-exception-handle branch February 15, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants