stm32 lptim driver sleeping forever depends on SYSTEM_CLOCK_SLOPPY_IDLE #67390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRASTM
force-pushed
the
issue65008
branch
6 times, most recently
from
47a4fde to
ca619cb
Compare
|
@r2r0 Is that fine with you ? |
|
@erwango It's Ok. |
erwango
requested changes
Jan 15, 2024
When CONFIG_SYSTEM_SLOPPY_IDLE is not set, then system can sleep for -1 means waking Up at the max possible counter value (INT_MAX) When CONFIG_SYSTEM_SLOPPY_IDLE is set sleeping K_TICKS_FOREVER means never wakingUp Signed-off-by: Francois Ramu <francois.ramu@st.com>
|
rebase on d7328ea To sleep forever, call the k_msleep()
|
zephyrbot
requested review from
ABOSTM,
andyross,
Desvauxm-st,
gautierg-st,
GeorgeCGV and
teburd
erwango
approved these changes
Feb 6, 2024
gautierg-st
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stm32 lptim driver is called by the application which wants to sleep forever.
It calls the k_msleep function with a int32_t ticks parameter meaning either never wakeUp or wakeUp on max possible timeout. This meaning depends on the the SYSTEM_CLOCK_SLOPPY_IDLE
when CONFIG_SYSTEM_CLOCK_SLOPPY_IDLE is set, then application is supposed to call k_msleep(K_TICKS_FOREVER); will stop lptim counting
when CONFIG_SYSTEM_CLOCK_SLOPPY_IDLE is not set, then application is supposed to call k_msleep(INT_MAX); and lptim will wakeUp the system at its max possible timeout value.
This PR just add comment to clarify this meaning.
Fixes #65008