-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sensors: Add driver for Aosong AGS10 TVOC sensor #67081
sensors: Add driver for Aosong AGS10 TVOC sensor #67081
Conversation
Hello @BDeliers, and thank you very much for your first pull request to the Zephyr project! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for contributing a new driver to Zephyr! I've put in an initial review to get things started. I recommend running your files through clang-format
as you'll likely be seeing several style/formatting errors from the CI run. Please feel free to ask any questions but people might be slow to respond until after the holiday.
3fca216
to
8226022
Compare
6b5e456
to
81beaa1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
fc57670
to
54e9894
Compare
Added support for Aosong AGS10 TVOC sensor Signed-off-by: Balthazar Deliers <bdeliers@bdeliers.com>
54e9894
to
005f2b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Hi @BDeliers! To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge. Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁 |
Add driver for Aosong AGS10 TVOC sensor