Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sensors: Add driver for Aosong AGS10 TVOC sensor #67081

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

BDeliers
Copy link
Contributor

Add driver for Aosong AGS10 TVOC sensor

Copy link

Hello @BDeliers, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

Copy link
Collaborator

@tristan-google tristan-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for contributing a new driver to Zephyr! I've put in an initial review to get things started. I recommend running your files through clang-format as you'll likely be seeing several style/formatting errors from the CI run. Please feel free to ask any questions but people might be slow to respond until after the holiday.

drivers/sensor/ags10/ags10.c Outdated Show resolved Hide resolved
drivers/sensor/ags10/ags10.c Outdated Show resolved Hide resolved
drivers/sensor/ags10/ags10.c Outdated Show resolved Hide resolved
drivers/sensor/ags10/ags10.c Outdated Show resolved Hide resolved
drivers/sensor/ags10/ags10.c Outdated Show resolved Hide resolved
drivers/sensor/ags10/Kconfig Outdated Show resolved Hide resolved
@BDeliers BDeliers force-pushed the feature/driver_ags10 branch from 3fca216 to 8226022 Compare December 31, 2023 13:47
@BDeliers BDeliers force-pushed the feature/driver_ags10 branch 2 times, most recently from 6b5e456 to 81beaa1 Compare January 9, 2024 20:59
tristan-google
tristan-google previously approved these changes Jan 9, 2024
Copy link
Member

@MaureenHelm MaureenHelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

drivers/sensor/ags10/CMakeLists.txt Outdated Show resolved Hide resolved
drivers/sensor/ags10/ags10.c Outdated Show resolved Hide resolved
@BDeliers BDeliers force-pushed the feature/driver_ags10 branch 3 times, most recently from fc57670 to 54e9894 Compare January 16, 2024 10:24
Added support for Aosong AGS10 TVOC sensor

Signed-off-by: Balthazar Deliers <bdeliers@bdeliers.com>
@BDeliers BDeliers force-pushed the feature/driver_ags10 branch from 54e9894 to 005f2b5 Compare January 16, 2024 10:25
@BDeliers BDeliers requested a review from MaureenHelm January 16, 2024 21:37
Copy link
Collaborator

@tristan-google tristan-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@MaureenHelm MaureenHelm merged commit bea34c5 into zephyrproject-rtos:main Jan 19, 2024
18 checks passed
Copy link

Hi @BDeliers!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Devicetree Binding PR modifies or adds a Device Tree binding area: Sensors Sensors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants