board: m5stack_m5dial: Add support for M5Dial IoT devkit #67065
Conversation
|
This PR depends on #67012 Support for m5dial still in progress. |
|
@kartben Maybe your are interested in supporting me again? ;-) |
I saw your other PR with the display driver so I was totally gonna ask you when the M5Dial board definition was gonna come 😬 |
MrMarteng
force-pushed
the
m5tack_m5dial
branch
from
0954f4f to
bd44075
Compare
Adding support for M5stack M5Dial IoT development kit. M5Dial features 1,28" round display, rotary button, beeper, touch-screen, real-time-clock. Signed-off-by: Martin Kiepfer <mrmarteng@teleschirm.org>
MrMarteng
force-pushed
the
m5tack_m5dial
branch
from
99cef7a to
9286669
Compare
|
It feels to me that it would be better to handle the M5Dial as a shield, with the StampS3 defined separately as an actual board. This way one could use M5Dial with e.g. a StampC3, or any other board with a compatible TBD "M5 stamp connector", and we would actually offer proper support for bare StampS3? |
MrMarteng
force-pushed
the
m5tack_m5dial
branch
from
9286669 to
d464a16
Compare
🤔 maybe your are right. I am having a look into that. Support for StampS3 is on the way as well. Another holiday week ahead 😏 |
Eheh, very nice! |
I just added a pr for the atomS3lite recently (#67084). |
MrMarteng
force-pushed
the
m5tack_m5dial
branch
2 times, most recently
from
210f22a to
9286669
Compare
|
M5Dial support has been reworked via shield instead of a separate board: #67253 |
| :align: center | ||
| :alt: M5Stack M5Dial | ||
|
|
||
| M5Stack M5Dial |
There was a problem hiding this comment.
| :align: center | |
| :alt: M5Stack M5Dial | |
| M5Stack M5Dial | |
| :align: center | |
| :alt: M5Stack M5Dial | |
| M5Stack M5Dial |
| rotary_left: rotary_left { | ||
| label = "rotary left"; | ||
| gpios = <&gpio1 8 GPIO_ACTIVE_LOW>; | ||
| zephyr,code = <INPUT_KEY_LEFT>; | ||
| }; | ||
|
|
||
| rotary_right: rotary_right { | ||
| label = "rotary right"; | ||
| gpios = <&gpio1 9 GPIO_ACTIVE_LOW>; | ||
| zephyr,code = <INPUT_KEY_RIGHT>; | ||
| }; |
There was a problem hiding this comment.
You may use gpio-qdec, I think.
qdec {
compatible = "gpio-qdec";
gpios = <&m5stack_stamps3_header 20 GPIO_ACTIVE_LOW>,
<&m5stack_stamps3_header 22 GPIO_ACTIVE_LOW>;
steps-per-period = <4>;
zephyr,axis = <INPUT_REL_WHEEL>;
sample-time-us = <2000>;
idle-timeout-ms = <200>;
};
Also works as an lvgl encoder input
lvgl_encoder_input {
compatible = "zephyr,lvgl-encoder-input";
rotation-input-code = <INPUT_REL_WHEEL>;
button-input-code = <INPUT_KEY_0>;
};
|
@MrMarteng not a full review, just a comment as I just spent some time playing with the M5Dial today :) Also used @joelguittet's work for pwm backlight control |
|
Lol I posted on the wrong PR :) will move to the other one, as it applies anyway |
Adding support for M5stack M5Dial IoT development kit.
M5Dial features 1,28" round display, rotary button, beeper, touch-screen, real-time-clock and a NFC/RFID reader.