-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
posix: implement clock_getcpuclockid() #67039
Conversation
3b1341d
to
6e917a6
Compare
Hi @cfriedt. I have addressed your review comments. Please take a look and let me know if any changes are needed. I will work on them. |
Hello @cfriedt. I have addressed your comments. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for your contribution! 🥳
This might need a respin after #67044 is merged, but it's good to get reviews from others for the time being.
Implements clock_getcpuclockid function Fixes zephyrproject-rtos#59954 Signed-off-by: Jai Arora <infolinesoni@gmail.com>
Adds ZTEST for clock_getcpuclockid function Signed-off-by: Jai Arora <infolinesoni@gmail.com>
patch to implement get_pid function Signed-off-by: Jai Arora <infolinesoni@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zephyr/tests/posix/headers/src/unistd_h.c Line 345 in e2dccab
is missed out from this PR, @jaiiarora would you be able to create a follow up PR? |
Sure @ycsin |
Patch implements clock_getcpuclockid
Fix for #59954
I have based my implementation around
Since zephyr only supports single process, access is allowed for clock ID only of that process specified by its process id (pid).