-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bluetooth: audio: implement bap broadcast assistant long read/write #66874
Merged
carlescufi
merged 5 commits into
zephyrproject-rtos:main
from
kruithofa:bap_long_read_write
Feb 1, 2024
Merged
Bluetooth: audio: implement bap broadcast assistant long read/write #66874
carlescufi
merged 5 commits into
zephyrproject-rtos:main
from
kruithofa:bap_long_read_write
Feb 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c8e969b
to
a7f9020
Compare
Thalley
requested changes
Jan 19, 2024
0d5d360
to
f9cc20c
Compare
753e116
to
c9ed252
Compare
Thalley
requested changes
Jan 23, 2024
fb7f753
to
23f18f6
Compare
Thalley
requested changes
Jan 29, 2024
Increase the buffer size to allow for long writes Signed-off-by: Andries Kruithof <andries.kruithof@nordicsemi.no>
Make sure that buffers are large enough and add semaphores so that we can do long reads Signed-off-by: Andries Kruithof <andries.kruithof@nordicsemi.no>
23f18f6
to
60fc233
Compare
Thalley
requested changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good now - But I think we may still have a corner case that isn't handled.
98ea2f9
to
247c24f
Compare
Add support for sending long notifications, coming from a long read, back to the application Signed-off-by: Andries Kruithof <andries.kruithof@nordicsemi.no>
In the scan delegator when modifying the source we only want to send a sync request to the upper layers if we are not yet synced, and not also on a state change Note that without this change the babblesim test for long writes will fail Signed-off-by: Andries Kruithof <andries.kruithof@nordicsemi.no> Scan del bugfix Signed-off-by: Andries Kruithof <andries.kruithof@nordicsemi.no>
Added a test for long write, long read, and notifications Signed-off-by: Andries Kruithof <andries.kruithof@nordicsemi.no>
247c24f
to
b279f4e
Compare
Thalley
approved these changes
Jan 31, 2024
larsgk
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the long read/long write for BAP broadcast assistant.
fixes #63362
fixes #64183