Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth: audio: implement bap broadcast assistant long read/write #66874

Merged
merged 5 commits into from
Feb 1, 2024

Conversation

kruithofa
Copy link
Collaborator

@kruithofa kruithofa commented Dec 22, 2023

Implements the long read/long write for BAP broadcast assistant.

fixes #63362
fixes #64183

@kruithofa kruithofa changed the title Bap long read write WIP: Bap long read write Dec 22, 2023
@kruithofa kruithofa requested a review from Thalley December 22, 2023 07:54
@kruithofa kruithofa force-pushed the bap_long_read_write branch from c8e969b to a7f9020 Compare January 18, 2024 15:27
@kruithofa kruithofa changed the title WIP: Bap long read write Bluetooth: audio: implement bap broadcast assistant long read/write Jan 19, 2024
@kruithofa kruithofa force-pushed the bap_long_read_write branch 2 times, most recently from fb7f753 to 23f18f6 Compare January 29, 2024 14:58
Andries Kruithof added 2 commits January 30, 2024 09:22
Increase the buffer size to allow for long writes

Signed-off-by: Andries Kruithof <andries.kruithof@nordicsemi.no>
Make sure that buffers are large enough and add
semaphores so that we can do long reads

Signed-off-by: Andries Kruithof <andries.kruithof@nordicsemi.no>
@kruithofa kruithofa force-pushed the bap_long_read_write branch from 23f18f6 to 60fc233 Compare January 30, 2024 09:40
Copy link
Collaborator

@Thalley Thalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good now - But I think we may still have a corner case that isn't handled.

@kruithofa kruithofa force-pushed the bap_long_read_write branch 2 times, most recently from 98ea2f9 to 247c24f Compare January 30, 2024 10:44
Andries Kruithof added 3 commits January 31, 2024 09:46
Add support for sending long notifications, coming
from a long read, back to the application

Signed-off-by: Andries Kruithof <andries.kruithof@nordicsemi.no>
In the scan delegator when modifying the source we only want to
send a sync request to the upper layers if we are not yet synced,
and not also on a state change

Note that without this change the babblesim test for long writes
will fail

Signed-off-by: Andries Kruithof <andries.kruithof@nordicsemi.no>

Scan del bugfix

Signed-off-by: Andries Kruithof <andries.kruithof@nordicsemi.no>
Added a test for long write, long read, and notifications

Signed-off-by: Andries Kruithof <andries.kruithof@nordicsemi.no>
@kruithofa kruithofa force-pushed the bap_long_read_write branch from 247c24f to b279f4e Compare January 31, 2024 08:46
@carlescufi carlescufi merged commit b707828 into zephyrproject-rtos:main Feb 1, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
5 participants