Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: mbox: Add nxp mbox multi-channel support #66746

Merged
merged 1 commit into from
Jan 4, 2024
Merged

drivers: mbox: Add nxp mbox multi-channel support #66746

merged 1 commit into from
Jan 4, 2024

Conversation

TomasGalbickaNXP
Copy link
Contributor

Current implementation of NXP mbox driver mbox_nxp_imx_mu is using only one channel 0.
This commit adds support for multiple mbox channels as is indented by mbox drivers.

Change done in .send api signaling mode leveraging provided channel id to select correct General Purpose Interrupt. Another change done in IRQHandler to check and handle all channels.

Copy link

Hello @TomasGalbickaNXP, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

Current implementation of NXP mbox driver mbox_nxp_imx_mu
is using only one channel 0.
This commit adds support for multiple mbox channels as is
indented by mbox drivers.

Change done in .send api signaling mode leveraging provided
channel id to select correct General Purpose Interrupt.
Another change done in IRQHandler to check and handle all
channels.

Signed-off-by: Tomas Galbicka <tomas.galbicka@nxp.com>
@dleach02
Copy link
Member

dleach02 commented Jan 3, 2024

Looks good. What platforms did you test this on?

@TomasGalbickaNXP
Copy link
Contributor Author

It's tested by follow-up PR #66754
Tested on these boards via sample/drivers/mbox:
MIMXRT1160-EVK
MIMXRT1170-EVK
MIMXRT1170-EVKB

@carlescufi carlescufi merged commit 89bd024 into zephyrproject-rtos:main Jan 4, 2024
18 checks passed
Copy link

github-actions bot commented Jan 4, 2024

Hi @TomasGalbickaNXP!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants