Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pm: state: Support setting custom data to a state #66295

Closed
wants to merge 1 commit into from

Conversation

ceolin
Copy link
Member

@ceolin ceolin commented Dec 7, 2023

Custom data is not used by the subsystem itself, and is freely available for a SoC to use as it sees fit. It can be used to SoCs expose a way to targets customize a state behavior.

@ceolin ceolin requested review from tmleman and nashif December 7, 2023 23:43
@ceolin ceolin force-pushed the pm/custom-state-data branch from b546ea2 to 834dc65 Compare December 8, 2023 05:20
Custom data is not used by the subsystem itself, and is freely available
for a SoC to use as it sees fit. It can be used to SoCs expose a way
to targets customize a state behavior.

Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
{
#ifdef CONFIG_PM_STATE_CUSTOM_DATA
for (int16_t i = 0; i < ARRAY_SIZE(cpus_states); i++) {
pm_state_info *state_info = cpus_states[i];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing struct keyword

{
#ifdef CONFIG_PM_STATE_CUSTOM_DATA
for (int16_t i = 0; i < ARRAY_SIZE(cpus_states); i++) {
pm_state_info *state_info = cpus_states[i];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing struct keyword


if ((state_info->state == state) &&
((state_info->substate_id == substate_id)) ||
(substate_id == PM_ALL_SUBSTATES)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing include of <zephyr/pm/policy.h> for PM_ALL_SUBSTATES definition

Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Feb 11, 2024
@github-actions github-actions bot closed this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants