drivers: serial: pl011: Fix bug in support of Ambiq UART #66255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
platform: Ambiq
Ambiq UART requires specific busy wait during initialization for propagating powering control registers, original k_busy_wait() used here generated a dead loop because k_busy_wait() relays on timer, who's driver is initialized after UART(UART init in PRE_KERNEL_1, timer init in PRE_KERNEL_2), use delay function in Ambiq HAL to replace k_busy_wait() is much suitable here. Signed-off-by: Bryan Zhu <bzhu@ambiq.com>
BryanZhuAM
force-pushed
the
driver_uart_fix
branch
from
0ba869d to
fff873a
Compare
fkokosinski
approved these changes
Dec 7, 2023
|
The vendor HAL calling here generates compiling error due to PL011 is a general driver which is not dedicate to Ambiq UART, I am cancelling this PR until I find a proper way to fix it |
|
Close this PR due to PL011 is a general driver which can not include vendor API inside |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ambiq UART requires specific busy wait during initialization for propagating powering control registers, original k_busy_wait() used here generated a dead loop because k_busy_wait() relays on timer, who's driver is initialized after UART(UART init in PRE_KERNEL_1, timer init in PRE_KERNEL_2), use delay function in Ambiq HAL to replace k_busy_wait() is much suitable here.
This issue impacts the OS's normal startup in apollo4p SOC