cmake: Show executable for memory report #66217
Conversation
|
Hello @hellesvik-nordic, and thank you very much for your first pull request to the Zephyr project! |
zephyrbot
requested review from
57300,
jeremybettis,
nashif,
nordicjm and
tejlmand
hellesvik-nordic
force-pushed
the
pr/memory_report_print_executable_path
branch
from
17d67cc to
55ac863
Compare
There was a problem hiding this comment.
instead of yet another way of doing what is already done, then please update this line instead to provide full path:
Line 1891 in b8856ae
Note, a small detail regarding COMMENT, make will always print all comments, but ninja will not due to the way the ninja generator works on post build commands.
So the COMMENT should be changed into an echo COMMAND to give desired behavior on using both make and ninja.
hellesvik-nordic
force-pushed
the
pr/memory_report_print_executable_path
branch
from
55ac863 to
d2c096c
Compare
|
Good point, as you say it should already be printed, I just did not see it as I just west(and therefore ninja) to build. |
you can actually use |
CMakeLists.txt
Outdated
| ${post_build_commands} | ||
| BYPRODUCTS | ||
| ${post_build_byproducts} | ||
| COMMENT "Generating files from ${KERNEL_ELF_NAME} for board: ${BOARD}" | ||
| COMMAND ${CMAKE_COMMAND} -E echo "Generating files from ${PROJECT_BINARY_DIR}/${KERNEL_ELF_NAME} for board: ${BOARD}" |
There was a problem hiding this comment.
minor nit, if you move the COMMAND up so it's the first echo command, then it's printed first before other post build commands.
POST_BUILD
COMMAND ${CMAKE_COMMAND} -E echo "Generating files from ${PROJECT_BINARY_DIR}/${KERNEL_ELF_NAME} for board: ${BOARD}"
${post_build_commands}
BYPRODUCTS
${post_build_byproducts}
There was a problem hiding this comment.
Somehow the memory report is still printed first:
There was a problem hiding this comment.
Somehow the memory report is still printed first:
Because the memory report is printed by the linker when using gcc, and is not a postbuild command.
It will only help in relation to other postbuild commands, such as image.py 😉
There was a problem hiding this comment.
I see
Moved it up now
hellesvik-nordic
force-pushed
the
pr/memory_report_print_executable_path
branch
from
d2c096c to
9ba3613
Compare
Firstly, COMMENT does not work for ninja. Therefore, change COMMENT to echo. With the addition of sysbuild, several memory reports can be printed for one build. Because of this, it is useful to know which executable each memory report is printed for, so adding full path to elf file. Signed-off-by: Sigurd Hellesvik <sigurd.hellesvik@nordicsemi.no>
hellesvik-nordic
force-pushed
the
pr/memory_report_print_executable_path
branch
from
9ba3613 to
0fbd456
Compare
|
Hi @hellesvik-nordic! To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge. Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁 |
With the addition of sysbuild, several memory reports can be printed for one build.
Because of this, it is useful to know which executable each memory report is printed for.