Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added xiao_esp32c3 conf and overlay files to allow proper compilation… #66190

Merged
merged 1 commit into from
Dec 7, 2023
Merged

added xiao_esp32c3 conf and overlay files to allow proper compilation… #66190

merged 1 commit into from
Dec 7, 2023

Conversation

rabarar
Copy link
Contributor

@rabarar rabarar commented Dec 5, 2023

… for the xiao_esp32c3 board

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

Hello @rabarar, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@kartben kartben linked an issue Dec 5, 2023 that may be closed by this pull request
Add required files to allow building sample net/wifi sample for XIAO ESP32C3 #66189
Closed
@rabarar rabarar closed this Dec 5, 2023
@rabarar
Copy link
Contributor Author

rabarar commented Dec 5, 2023 •
edited
Loading

sample: net: wifi: boards: added missing .conf and .overlay files for xiao_esp32c3

The conf and overlay files to properly compile the wifi samples were omitted for the Xiao_esp32c3 board. I've added those two files and confirmed that the sample properly compiles and runs.

Signed-off-by: Rob Baruch <rabarar robertbaruch@mac.com>

@rabarar rabarar reopened this Dec 5, 2023
@rabarar rabarar closed this Dec 5, 2023
@rabarar rabarar reopened this Dec 5, 2023
@kartben
Copy link
Collaborator

kartben commented Dec 5, 2023 •
edited
Loading

sample: net: wifi: boards: added missing .conf and .overlay files for xiao_esp32c3

The conf and overlay files to properly compile the wifi samples were omitted for the Xiao_esp32c3 board. I've added those two files and confirmed that the sample properly compiles and runs.

Signed-off-by: Rob Baruch robertbaruch@mac.com

If you actually amend your commit to be that (except "samples:" instead of "sample:"), it should OK! Note that your committee name also need to be update to be "Robert Baruch" not "rabarar".
Also you should not have to close the PR while working through this, just force push your updates. Thanks!

@rabarar
Copy link
Contributor Author

rabarar commented Dec 5, 2023

samples: net: wifi: boards: added missing .conf and .overlay files for xiao_esp32c3

The conf and overlay files to properly compile the wifi samples were omitted for the Xiao_esp32c3 board. I've added those two files and confirmed that the sample properly compiles and runs.

Signed-off-by: Robert Baruch robertbaruch@mac.com

@rabarar
Copy link
Contributor Author

rabarar commented Dec 5, 2023

I'm missing it - if someone what's to give me the copy of how they'd like this to appear to allow it to pass - feel free - I've tried and I'm not getting past the Compliance Check... Best, Rob

@kartben
Copy link
Collaborator

kartben commented Dec 5, 2023

You need to actually update your actual commit, as that's what ends up in the code repository eventually, not the PR contents :)

git commit --amend --author "Robert Baruch <robertbaruch@mac.com>" --signoff

... Update the commit message title and description 

git push --force

@rabarar
Copy link
Contributor Author

rabarar commented Dec 5, 2023 via email

@rabarar
Copy link
Contributor Author

rabarar commented Dec 5, 2023 via email

@kartben
Copy link
Collaborator

kartben commented Dec 5, 2023 •
edited
Loading

Almost there it seems
The entirety of the commit message should literally read.

samples: net: wifi: add missing .conf and .overlay files for xiao_esp32c3

The conf and overlay files to properly compile the wifi samples were
omitted for the Xiao_esp32c3 board. I've added those two files and confirmed
that the sample properly compiles and runs.  

Signed-off-by: Robert Baruch <robertbaruch@mac.com>

Note that I've made sure to wrap lines at 72 characters as per the guidelines
Going through git commit --amend with this text as a full replacement for what you currently have should do the trick...

@rabarar
Copy link
Contributor Author

rabarar commented Dec 5, 2023 via email

@kartben
Copy link
Collaborator

kartben commented Dec 5, 2023

I am not sure what tool/editor your using for Git but fwiw your commit message actually looks like this: https://github.com/rabarar/zephyr/commit/934ba0a2fa253a9aedc0e4929e4e152732db3dfd , i.e. your successive changes have all been appended to one another?

@rabarar
Copy link
Contributor Author

rabarar commented Dec 5, 2023 via email

@rabarar
Copy link
Contributor Author

rabarar commented Dec 5, 2023 via email

@rabarar
samples: net: wifi: boards: added missing files for xiao_esp32c3
501f9b5 
The conf and overlay files to properly compile the wifi samples were
omitted for the Xiao_esp32c3 board. I've added those two files and
confirmed that the sample properly compiles and runs.

Signed-off-by: Robert Baruch <robertbaruch@mac.com>
@fabiobaltieri fabiobaltieri merged commit 5e08f73 into zephyrproject-rtos:main Dec 7, 2023
13 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

Hi @rabarar!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvioalves sylvioalves sylvioalves approved these changes

@jukkar jukkar jukkar approved these changes

@kartben kartben Awaiting requested review from kartben

@krish2718 krish2718 Awaiting requested review from krish2718

@nashif nashif Awaiting requested review from nashif

@rlubos rlubos Awaiting requested review from rlubos

Assignees

@jukkar jukkar

Labels
area: Networking area: Samples Samples area: Wi-Fi Wi-Fi
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add required files to allow building sample net/wifi sample for XIAO ESP32C3
6 participants
@rabarar @kartben @jukkar @sylvioalves @fabiobaltieri @zephyrbot