-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: adc: Add Microchip MCP3914 SPI 8ch ADC driver #65646
Conversation
38b3ecd
to
7be2360
Compare
7be2360
to
f0cca15
Compare
Opening this up for a quick review. We do have a few things to add for our own app;
There are two things I would like to get feedback on early;
|
f0cca15
to
275a1d0
Compare
0d38d20
to
17f21af
Compare
63c8cf6
to
899a8b2
Compare
899a8b2
to
2971bd9
Compare
New driver for the above chip on SPI bus. Runs in async, interrupt driven mode only. Basic chip features supported at this stage. Signed-off-by: Dean Sellers <dsellers@evos.com.au>
2971bd9
to
4bdf724
Compare
@dean-at-evos I also needed mcp3914 driver for zephyr found your pull request. I am testing it with STM32G491 (not able to successfully test it yet). Also added few comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still working on review .. few initial comments.
Thanks for your interest. TLDR; I'll get to the review soon. I am on another project for a month or two, but I am coming back to this, Q2 24 You say you haven't been able to test it. Does that mean it doesn't [build|load|work] for you, or you just haven't had the [hardware|time] to do it? I have had a machine running with this driver (two chips) for a 16 channel system for a few months now, but that is just on one SOC. If you need help with implementing to get things running let me know, .... I'll look at the review soon |
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
Apologies but this is no longer stale ... back in active development :) |
New driver for the above chip on SPI bus. Runs in async, interrupt driven mode only. Basic chip features supported at this stage.
A new driver for the microchip mcp3914 on SPI bus. Tested on ESP32c3 with basic functionality.