input: kbd_matrix: add an kbd_matrix_state shell command #65628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiobaltieri
force-pushed
the
keyboard-input-shell
branch
10 times, most recently
from
2dc2a4e to
a83995d
Compare
fabiobaltieri
force-pushed
the
keyboard-input-shell
branch
2 times, most recently
from
e434394 to
861f221
Compare
Add a print helper define for the keyboard matrix row paired with the row typedef. Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
fabiobaltieri
force-pushed
the
keyboard-input-shell
branch
from
861f221 to
5d381cb
Compare
|
@gmarull @keith-zephyr ping |
keith-zephyr
reviewed
Dec 7, 2023
subsys/input/input_utils.c
Outdated
| @@ -119,6 +265,12 @@ SHELL_STATIC_SUBCMD_SET_CREATE( | |||
| "usage: dump <on|off>", | |||
| input_cmd_dump, 2, 0), | |||
| #endif /* CONFIG_INPUT_EVENT_DUMP */ | |||
| #ifdef CONFIG_INPUT_KBD_MATRIX_STATE | |||
There was a problem hiding this comment.
Can you add some documentation that guides the user on how to use and interpret the results from this command?
There was a problem hiding this comment.
hey I'm working on a doc page covering all the keyboard options and gpio keyboard modes (there's plenty enough to justify a whole page imo), will cover that there, I think it'll be the proper context
fabiobaltieri
force-pushed
the
keyboard-input-shell
branch
2 times, most recently
from
266e6b4 to
0f02a76
Compare
keith-zephyr
previously approved these changes
Dec 7, 2023
kartben
requested changes
Dec 8, 2023
fabiobaltieri
force-pushed
the
keyboard-input-shell
branch
from
0f02a76 to
8f1162f
Compare
Add a "input kbd_matrix_state" shell command. This prints the state of a keyboard matrix in a much more compact representation than the normal input event dump, but also keeps track of any key seen during the execution and reports that on the "off" command. The output can be used to help setting the actual-key-mask property. Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
Add a test for the kbd_matrix_state shell command, both 8 and 16 bit row variants. Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
Enable INPUT_SHELL and INPUT_KBD_MATRIX_STATE by default if the sample is compiled with CONFIG_SHELL=y. This makes it easier to use the shell commands in the sample by just enabling the shell and let any help command turn on automatically. Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
fabiobaltieri
force-pushed
the
keyboard-input-shell
branch
from
8f1162f to
894d2bf
Compare
kartben
approved these changes
Dec 8, 2023
keith-zephyr
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a "input kbd_matrix_state" shell command. This prints the state of a keyboard matrix in a much more compact representation than the normal input event dump, but also keeps track of any key seen during the execution and reports that on the "off" command. The output can be used to help setting the actual-key-mask property (#65703).