Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards: arm: add BeaglePlay on-board CC1352 #64718

Merged
merged 1 commit into from
Sep 29, 2024
Merged

boards: arm: add BeaglePlay on-board CC1352 #64718

merged 1 commit into from
Sep 29, 2024

Conversation

Ayush1325
Copy link
Member

@Ayush1325 Ayush1325 commented Nov 2, 2023 •
edited
Loading

Add basic support for BeaglePlay, a TI AM6254 SoC based development board with a CC1352P7 wireless microcontroller for supporting software defined 2.4GHz and SubGHz wireless protocols. Support for running Zephyr on the quad-A53 SoC or the programmable M4 on the SoC would be provided separately.

Tested hello world and zperf.

See https://beagleplay.org/ for details.

doc preview: https://builds.zephyrproject.io/zephyr/pr/64718/docs/boards/beagle/beagleplay/doc/beagleplay_cc1352p7.html

@Ayush1325 Ayush1325 force-pushed the beagleplay-hello-world branch from 324d5d9 to 5619eb2 Compare November 2, 2023 10:19
@Ayush1325 Ayush1325 mentioned this pull request Nov 10, 2023
Closed
@Ayush1325 Ayush1325 force-pushed the beagleplay-hello-world branch from 5619eb2 to cb5d3f0 Compare November 10, 2023 10:10
cfriedt
cfriedt previously approved these changes Nov 11, 2023
View reviewed changes
Copy link
Member

@cfriedt cfriedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlescufi
Copy link
Member

@vaishnavachath PTAL

@vaishnavachath
Copy link
Collaborator

@vaishnavachath PTAL

@carlescufi it seems like the misc-flasher changes are incomplete, I am not sure how an user would flash to this target without reading the instructions at board.cmake and fixing up the flashing script manually. Other that no concerns with this PR.

vaishnavachath
vaishnavachath requested changes Dec 16, 2023
View reviewed changes
boards/arm/beagle_play_cc1352/board.cmake Outdated Show resolved Hide resolved
boards/arm/beagle_play_cc1352/doc/index.rst Outdated Show resolved Hide resolved
@Ayush1325 Ayush1325 force-pushed the beagleplay-hello-world branch from cb5d3f0 to 731b69d Compare January 6, 2024 20:12
@Ayush1325 Ayush1325 force-pushed the beagleplay-hello-world branch from 731b69d to 418416e Compare January 10, 2024 17:49
@Ayush1325
Copy link
Member Author

@vaishnavachath Can we tackle the question of adding cc1352-flasher in a separate PR. I have updated the docs to install the flasher out of tree for now since #67229 was blocked.

I will be working with upstream cc2538-bsl to make the flashing situation better but it will take a while since I do not control those projects.

@vaishnavachath vaishnavachath self-requested a review January 10, 2024 19:36
vaishnavachath
vaishnavachath previously approved these changes Jan 10, 2024
View reviewed changes
boards/arm/beagle_play_cc1352/doc/index.rst Outdated Show resolved Hide resolved
kartben
kartben requested changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is nice! Some feedback on the doc -- thanks!

boards/arm/beagle_play_cc1352/doc/index.rst Outdated Show resolved Hide resolved
boards/arm/beagle_play_cc1352/doc/index.rst Outdated Show resolved Hide resolved
boards/arm/beagle_play_cc1352/doc/index.rst Outdated Show resolved Hide resolved
boards/arm/beagle_play_cc1352/doc/index.rst Outdated Show resolved Hide resolved
@Ayush1325 Ayush1325 force-pushed the beagleplay-hello-world branch 6 times, most recently from 4103d9a to 5127377 Compare January 11, 2024 18:08
@Ayush1325 Ayush1325 mentioned this pull request Jan 16, 2024
Merged
@Ayush1325 Ayush1325 force-pushed the beagleplay-hello-world branch from 762f362 to 8a99512 Compare February 6, 2024 12:39
@jadonk @Ayush1325
boards: beagle: add BeaglePlay on-board CC1352P7
e7af2f5 
Add support for BeaglePlay, a TI AM6254 SoC based development board with a
CC1352P7 wireless microcontroller for supporting software defined 2.4GHz
and SubGHz wireless protocols. Support for running Zephyr on the
quad-A53 SoC or the programmable M4 on the SoC would be provided
separately.

See https://beagleplay.org for details.

Signed-off-by: Jason Kridner <jkridner@beagleboard.org>
Signed-off-by: Ayush Singh <ayush@beagleboard.org>
@Ayush1325 Ayush1325 force-pushed the beagleplay-hello-world branch from 9d0e607 to e7af2f5 Compare September 20, 2024 18:43
cfriedt
cfriedt approved these changes Sep 21, 2024
View reviewed changes
Copy link
Member

@cfriedt cfriedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I think the comments from @vaishnavachath were addressed, but please wait for his approval before merging.

@Ayush1325
Copy link
Member Author

LGTM - I think the comments from @vaishnavachath were addressed, but please wait for his approval before merging.

Sure. But the only change since his approval was a rebase due to a conflict. So I don't think there should be much problem.

jadonk
jadonk approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@jadonk jadonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jadonk
Copy link
Contributor

jadonk commented Sep 24, 2024

Where are the requested changes from @gmarull ?

@Ayush1325
Copy link
Member Author

Where are the requested changes from @gmarull ?

Moved pinctrl to soc config. See soc/ti/simplelink/cc13x2x7_cc26x2x7/Kconfig

@mmahadevan108
Copy link
Collaborator

@Ayush1325 , have you addressed the comments from @gmarull

@Ayush1325
Copy link
Member Author

@Ayush1325 , have you addressed the comments from @gmarull

Maybe my previous message was not clear enough. I am assuming the comment everyone is referencing is the following: #64718 (comment)

As I stated earlier, boards/beagle/beagleplay/beagleplay_cc1352p7_defconfig does not contain any config options regarding pinctrl. I removed CONFIG_PINCTRL_DYNAMIC=y and CONFIG_PINCTRL_CC13XX_CC26XX=y since they are automatically selected and moved CONFIG_PINCTRL=y to soc/ti/simplelink/cc13x2x7_cc26x2x7/Kconfig similar to what is being done for espressif.

It just seems like github does not automatically dismiss the review, but if you click the "See review option", it does point to a resolved comment (because well, I have addressed everything raised in that comment to the best of my knowledge).

@mmahadevan108
Copy link
Collaborator

@gmarull, can you please revisit this PR.

@mmahadevan108 mmahadevan108 dismissed gmarull’s stale review September 27, 2024 13:59

Comments addressed.

@henrikbrixandersen henrikbrixandersen merged commit 2eda5f3 into zephyrproject-rtos:main Sep 29, 2024
24 checks passed
@Ayush1325 Ayush1325 deleted the beagleplay-hello-world branch September 29, 2024 19:33
Ayush1325 added a commit to Ayush1325/zephyr that referenced this pull request Oct 4, 2024
@Ayush1325
boards: ti: cc1352p7_launchpad: Remove PINCTRL
a3de069 
- PINCTRL is now being selected by
  soc/ti/simplelink/cc13x2x7_cc26x2x7/Kconfig, so no need to add to
  diffconfig.
- See zephyrproject-rtos#64718 (comment)

Signed-off-by: Ayush Singh <ayush@beagleboard.org>
Ayush1325 added a commit to Ayush1325/zephyr that referenced this pull request Oct 4, 2024
@Ayush1325
boards: ti: beagleconnect_freedom: Remove PINCTRL
073eda0 
- PINCTRL is now being selected by
  soc/ti/simplelink/cc13x2x7_cc26x2x7/Kconfig, so no need to add to
  diffconfig.
- See zephyrproject-rtos#64718 (comment)

Signed-off-by: Ayush Singh <ayush@beagleboard.org>
@Ayush1325 Ayush1325 mentioned this pull request Oct 4, 2024
Merged
nashif pushed a commit that referenced this pull request Oct 8, 2024
@Ayush1325 @nashif
boards: ti: cc1352p7_launchpad: Remove PINCTRL
89995d0 
- PINCTRL is now being selected by
  soc/ti/simplelink/cc13x2x7_cc26x2x7/Kconfig, so no need to add to
  diffconfig.
- See #64718 (comment)

Signed-off-by: Ayush Singh <ayush@beagleboard.org>
nashif pushed a commit that referenced this pull request Oct 8, 2024
@Ayush1325 @nashif
boards: ti: beagleconnect_freedom: Remove PINCTRL
c506cf5 
- PINCTRL is now being selected by
  soc/ti/simplelink/cc13x2x7_cc26x2x7/Kconfig, so no need to add to
  diffconfig.
- See #64718 (comment)

Signed-off-by: Ayush Singh <ayush@beagleboard.org>
@Ayush1325 Ayush1325 mentioned this pull request Oct 9, 2024
Merged
coreboot-bot pushed a commit to coreboot/zephyr-cros that referenced this pull request Oct 11, 2024
@Ayush1325
boards: ti: cc1352p7_launchpad: Remove PINCTRL
70034d4 
- PINCTRL is now being selected by
  soc/ti/simplelink/cc13x2x7_cc26x2x7/Kconfig, so no need to add to
  diffconfig.
- See zephyrproject-rtos/zephyr#64718 (comment)

(cherry picked from commit 89995d0)

Original-Signed-off-by: Ayush Singh <ayush@beagleboard.org>
GitOrigin-RevId: 89995d0
Cr-Build-Id: 8734380568354140561
Cr-Build-Url: https://cr-buildbucket.appspot.com/build/8734380568354140561
Copybot-Job-Name: zephyr-main-copybot-downstream
Change-Id: I23137f6645a7d885061b97ced36655ed26303299
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5915879
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
coreboot-bot pushed a commit to coreboot/zephyr-cros that referenced this pull request Oct 11, 2024
@Ayush1325
boards: ti: beagleconnect_freedom: Remove PINCTRL
4b6c76b 
- PINCTRL is now being selected by
  soc/ti/simplelink/cc13x2x7_cc26x2x7/Kconfig, so no need to add to
  diffconfig.
- See zephyrproject-rtos/zephyr#64718 (comment)

(cherry picked from commit c506cf5)

Original-Signed-off-by: Ayush Singh <ayush@beagleboard.org>
GitOrigin-RevId: c506cf5
Cr-Build-Id: 8734380568354140561
Cr-Build-Url: https://cr-buildbucket.appspot.com/build/8734380568354140561
Copybot-Job-Name: zephyr-main-copybot-downstream
Change-Id: I5431b1c17a29d33a8ba37cd071afcf13a103dcf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5915880
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
@vaishnavachath vaishnavachath mentioned this pull request Oct 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaishnavachath vaishnavachath vaishnavachath approved these changes

@cfriedt cfriedt cfriedt approved these changes

@kartben kartben kartben approved these changes

@jadonk jadonk jadonk approved these changes

@nashif nashif Awaiting requested review from nashif

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@galak galak Awaiting requested review from galak

@con-pax con-pax Awaiting requested review from con-pax

@jukkar jukkar Awaiting requested review from jukkar

@rlubos rlubos Awaiting requested review from rlubos

@tbursztyka tbursztyka Awaiting requested review from tbursztyka

@gmarull gmarull Awaiting requested review from gmarull

@vanti vanti Awaiting requested review from vanti

@nordicjm nordicjm Awaiting requested review from nordicjm

Assignees

@jadonk jadonk

Labels
area: Networking area: Samples Samples platform: BeagleBoard BeagleBoard.org Foundation platform: TI SimpleLink Texas Instruments SimpleLink MCU
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.