ev11l78a: configure DAC peripheral #62478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flameeyes
requested review from
nashif,
galak,
soburi and
MaureenHelm
as code owners
This was referenced Sep 10, 2023
zephyrbot
added
platform: Microchip SAM
zephyrbot
requested review from
attie-argentum,
martinjaeger,
mnkp,
nandojve,
pdgendt and
stephanosio
martinjaeger
requested changes
Sep 10, 2023
|
You need rebase : ) |
|
Ping |
The ATSAMD20E16 used in this board only has 8KiB SRAM, so the defaults are not really suitable for anything close to useful, particularly the sink sample that most closely resembles the original demo for the board. This should also allow more tests not to be skipped for this board as otherwise they overflow RAM usage. Signed-off-by: Diego Elio Pettenò <flameeyes@meta.com>
This configures the DAC in the same way as it is configured for the arduino_zero and other similar boards. It also includes the board in the DAC tests. Signed-off-by: Diego Elio Pettenò <flameeyes@meta.com>
|
Rebased, This still include the commit from #61797 because of how Sapling handles the stack — there's a ReviewStack UI that wraps around the pull request, otherwise feel free to wait for the review until the dependent change is merged. |
|
Hi @Flameeyes , The #61797 got in. |
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ev11l78a: configure DAC peripheral
This configures the DAC in the same way as it is configured for the
arduino_zero and other similar boards.
It also includes the board in the DAC tests.
Signed-off-by: Diego Elio Pettenò flameeyes@meta.com
Stack created with Sapling. Best reviewed with ReviewStack.