Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: arm: Add BeaglePlay CC1352 #58877

Closed

Conversation

jadonk
Copy link
Contributor

@jadonk jadonk commented Jun 6, 2023

This is under arm, not arm64, because it is for the M4 on the CC1352P7, not the A53s on AM6254.

For information about BeaglePlay, see https://beagleplay.org.

jadonk added 3 commits June 6, 2023 00:05
See TI application note SWRA640G section 6.4. "Tuning the HF
Oscillator".

Signed-off-by: Jason Kridner <jkridner@beagleboard.org>
See TI application note SWRA640G section 6.4. "Tuning the HF
Oscillator".

Signed-off-by: Jason Kridner <jkridner@beagleboard.org>
Add support for BeaglePlay, a TI AM6254 SoC based development board with a
CC1352P7 wireless microcontroller for supporting software defined 2.4GHz
and SubGHz wireless protocols. Support for running Zephyr on the
quad-A53 SoC or the programmable M4 on the SoC would be provided
separately.

See https://beagleplay.org for details.

Signed-off-by: Jason Kridner <jkridner@beagleboard.org>
@zephyrbot zephyrbot added the platform: TI SimpleLink Texas Instruments SimpleLink MCU label Jun 6, 2023
@jadonk jadonk force-pushed the add-beagleplay-cc1352 branch from 28cb071 to 23ed8a7 Compare June 6, 2023 04:36
Add support for BeaglePlay, a TI AM6254 SoC based development board with a
CC1352P7 wireless microcontroller for supporting software defined 2.4GHz
and SubGHz wireless protocols. Support for running Zephyr on the
quad-A53 SoC or the programmable M4 on the SoC would be provided
separately.

See https://beagleplay.org for details.

Signed-off-by: Jason Kridner <jkridner@beagleboard.org>
@jadonk jadonk force-pushed the add-beagleplay-cc1352 branch from 23ed8a7 to 554a9ad Compare June 6, 2023 04:48
@vaishnavachath vaishnavachath self-assigned this Jun 6, 2023
@cfriedt
Copy link
Member

cfriedt commented Jun 6, 2023

@jadonk, @vaishnavachath - subtle change with SYS_INIT() now - no const struct device *dev needed any more.

Documentation issue is unrelated and should be solved by a rebase (when there is a fix in).

@cfriedt
Copy link
Member

cfriedt commented Jun 6, 2023

Feature freeze right now in the release cycle, so 10 days before this can be merged.
https://github.com/zephyrproject-rtos/zephyr/wiki/Release-Management

static int board_antenna_init(const struct device *dev)
{
ARG_UNUSED(dev);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jadonk can you please drop const struct device *dev ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this was just changed to void somewhat recently

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ayush1325 Ping, since you are actively working on BeagleConnect freedom and Beagleplay, can you fixup the minor changes required in this PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vaishnavachath This PR totally slipped by radar. I already do have a PR for beagleplay on-board cc1352: #64718. Other than caparray delta (which I am planning to add after #65048, my PR also contains everything rebased on upstream zephyr

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem @Ayush1325 , can you add the Caparray delta to #65048 (new commit) rather than creating a new PR for that alone? and please confirm if this can be closed as duplicate.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vaishnavachath Yes, I will add caparray to #65048

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Oct 1, 2023
@kartben kartben removed the Stale label Oct 1, 2023
@vaishnavachath
Copy link
Collaborator

Closing as this PR is a duplicate, the new PR #65048 and #64718 has the same changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: TI SimpleLink Texas Instruments SimpleLink MCU
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants