Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tfm: Add TF-M interface include headers always #53097

Closed
wants to merge 1 commit into from
Closed

tfm: Add TF-M interface include headers always #53097

wants to merge 1 commit into from

Conversation

joerchan
Copy link
Contributor

Add the TF-M interface include headers to the zephyr includes when building with TF-M.

Signed-off-by: Joakim Andersson joakim.andersson@nordicsemi.no

@joerchan
tfm: Add TF-M interface include headers always
32cc345 
Add the TF-M interface include headers to the zephyr includes when
building with TF-M.

Signed-off-by: Joakim Andersson <joakim.andersson@nordicsemi.no>
@zephyrbot zephyrbot added area: ARM ARM (32-bit) Architecture platform: nRF Nordic nRFx manifest-trusted-firmware-m area: Crypto / RNG area: USB Universal Serial Bus area: TF-M ARM Trusted Firmware-M (TF-M) labels Dec 15, 2022
@joerchan
Copy link
Contributor Author

Note. This was attempted earlier and had some issues with mbedtels psa headers. Running CI on this now to discover if there are issues still.

jfischer-no
jfischer-no reviewed Dec 15, 2022
View reviewed changes
Copy link
Collaborator

@jfischer-no jfischer-no left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused, I see +0 -60 and read "Add TF-M interface...", please enlighten me.

@joerchan
Copy link
Contributor Author

I am confused, I see +0 -60 and read "Add TF-M interface...", please enlighten me.

Hehe, yeah I thought that was a bit funny. The important change is here:
https://github.com/zephyrproject-rtos/zephyr/pull/53097/files#diff-dc28570be9d838c291b4be7f1ea2436d81b17f095892a52869cd3cd88317c599

I added it in the zephyr include directories, and removed it from the private list of the tfm_api library.
This ended up as an all-delete diff.

@joerchan
Copy link
Contributor Author

Note. This was attempted earlier and had some issues with mbedtels psa headers. Running CI on this now to discover if there are issues still.

Looking at CI there is clearly issues here still.
Will have to do more investigation on how this can be managed.

@desowin desowin requested review from tmon-nordic and removed request for desowin January 26, 2023 13:27
@github-actions
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Mar 28, 2023
@joerchan joerchan removed the Stale label Mar 28, 2023
@github-actions
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label May 28, 2023
@PavelVPV PavelVPV mentioned this pull request Jun 8, 2023
Closed
@github-actions github-actions bot closed this Jun 11, 2023
@joerchan joerchan reopened this Jun 11, 2023
@github-actions github-actions bot removed the Stale label Jun 12, 2023
@joerchan joerchan marked this pull request as draft June 12, 2023 10:58
@github-actions
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Aug 12, 2023
@joerchan joerchan removed the Stale label Aug 23, 2023
@github-actions
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Oct 23, 2023
@joerchan joerchan removed the Stale label Oct 25, 2023
@joerchan
Copy link
Contributor Author

joerchan commented Dec 7, 2023

🏳️

@joerchan joerchan closed this Dec 7, 2023
@joerchan joerchan deleted the tfm-include-interface-headers branch December 7, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfischer-no jfischer-no jfischer-no left review comments

@tmon-nordic tmon-nordic tmon-nordic approved these changes

@SebastianBoe SebastianBoe SebastianBoe approved these changes

@ioannisg ioannisg Awaiting requested review from ioannisg

@stephanosio stephanosio Awaiting requested review from stephanosio

@microbuilder microbuilder Awaiting requested review from microbuilder

@nashif nashif Awaiting requested review from nashif

@carlescufi carlescufi Awaiting requested review from carlescufi

@anangl anangl Awaiting requested review from anangl

@bbolen bbolen Awaiting requested review from bbolen

@carlocaione carlocaione Awaiting requested review from carlocaione

@ceolin ceolin Awaiting requested review from ceolin

@galak galak Awaiting requested review from galak

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@theotherjimmy theotherjimmy Awaiting requested review from theotherjimmy

Assignees

@microbuilder microbuilder

Labels
area: ARM ARM (32-bit) Architecture area: Counter area: Crypto / RNG area: TF-M ARM Trusted Firmware-M (TF-M) area: USB Universal Serial Bus manifest-trusted-firmware-m platform: nRF Nordic nRFx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@joerchan @SebastianBoe @jfischer-no @tmon-nordic @microbuilder @zephyrbot