Skip to content

Commit

Permalink
twister: fix issue twister with --device-testing on Windows
Browse files Browse the repository at this point in the history
There is an incorrect logic that causes twister with
--device-testing to skip all tests on Windows. Correct
the logical condition.

Signed-off-by: Dat Nguyen Duy <dat.nguyenduy@nxp.com>
  • Loading branch information
Dat-NguyenDuy authored and nashif committed Dec 4, 2024
1 parent 60a4327 commit 1069f57
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions scripts/pylib/twister/twisterlib/testinstance.py
Original file line number Diff line number Diff line change
Expand Up @@ -264,9 +264,9 @@ def check_runnable(self,
simulation = options.sim_name

simulator = self.platform.simulator_by_name(simulation)
if os.name == 'nt':
if os.name == 'nt' and simulator:
# running on simulators is currently supported only for QEMU on Windows
if (not simulator) or simulator.name not in ('na', 'qemu'):
if simulator.name not in ('na', 'qemu'):
return False

# check presence of QEMU on Windows
Expand Down

0 comments on commit 1069f57

Please sign in to comment.