Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stm32h7xx_hal driver partial update to v1.11.3 #226

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

FRASTM
Copy link
Collaborator

@FRASTM FRASTM commented Aug 9, 2024

Some changes applied on the stm32h7xx_hal_driver
v1.11.3 are reported here. Until the stm32CubeH7 module is updated.

The version identified by the https://github.com/STMicroelectronics/STM32CubeH7 is v1.11.2

So that stm32H7 serie is not updated

However, the
https://github.com/STMicroelectronics/stm32h7xx_hal_driver/tree/b2b4c45001f1b6b72ae449713607896fd6ca4c6b
is more a v1.11.3

with some important changes like the one on the ospi hal driver which is put in this PR

Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1.11.3 is this branch, but it doesn't contain the commit you mention. Also, picking up a commit (two from what I could tell), would require a clear update of the README

Since ST STM32Cube team is making use of rolling release in their HAL repo, we indeed need to adapt our cube update strategy, but we need to maintain clarity on our status.

I see 2 solutions:
-A] Cherry pick commits interesting for zephyr
-B] Point to the latest commit on top of the repo at a given time

A] allows to cherry pick only what we're interested in and be confident in our fork stability. Though, updates to tagged released could be trickier. And also, we need to display clearly our status vs original branch (ie clear update of the fork README)
With B],it will be more work, as we need to ensure the stability of all the commits we take (using non regression tests or commit per commit analysis), but updates should then be easier and status clearer at anytime.

I let you check what is the best in current case.

Some changes applied on the stm32h7xx_hal_driver
v1.11.3 are reported here. Until the stm32CubeH7 module
is updated.

Signed-off-by: Francois Ramu <francois.ramu@st.com>
@FRASTM
Copy link
Collaborator Author

FRASTM commented Aug 30, 2024

Adding references in the README

@FRASTM FRASTM requested a review from gautierg-st August 30, 2024 14:46
@erwango erwango merged commit 8539df7 into zephyrproject-rtos:main Sep 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants