stm32h7: fix TX timestamp check #220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like the original code was a bad copy-paste from H5/H7 HALs. ETH_DMATXDESC_LS and ETH_DMATXDESC_TTSS are flags from the DuESC0 register. This fix allows to effectively set the TX timestamp properly when there is one. Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
erwango
requested changes
Jun 27, 2024
There was a problem hiding this comment.
I'm fine with the change, but please:
- Update README file
hal_stm32/stm32cube/stm32f7xx/README
Line 37 in d12e21e
- Open a ticket in official HAL repo to follow up the fix (https://github.com/STMicroelectronics/STM32CubeF7)
|
@marwaiehm-st Since @kartben is busy, would you mind taking over this change ? |
Ok |
|
This PR is replaced by #232 |
Thanks @marwaiehm-st. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the original code was a bad copy-paste from H5 HAL. ETH_DMATXDESC_LS and ETH_DMATXDESC_TTSS are flags from the DESC0 register. This allows to effectively et the TX timestamp properly when there is one.
I wouldn't be surprised if more of such mix-ups of DESC0/1 vs., DESC2/3 would be to be found in the file but I didn't really review this.