beagleconnect_freedom: Add pwm support #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Ayush1325
commented
Jun 5, 2024
Ayush1325
commented
- Replace pwm_set_cycles with pwm_set_pulse_dt.
- Add check to ensure that pwm pin is ready
- Fix intendation
- Fix incorrect PWM MB 2 pin number
- Add pwms property
soburi
reviewed
Jun 10, 2024
- Replace pwm_set_cycles with pwm_set_pulse_dt. - Add check to ensure that pwm pin is ready Signed-off-by: Ayush Singh <ayushdevel1325@gmail.com>
- Fix intendation - Fix incorrect PWM MB 2 pin number - Add pwms property Signed-off-by: Ayush Singh <ayushdevel1325@gmail.com>
soburi
approved these changes
Jun 10, 2024
DhruvaG2000
approved these changes
Jun 13, 2024
|
@DhruvaG2000 So, the thing is that this works as well as pwm works for bcf in zephyr (which means not very well). However, the problem seems to be in the zephyr driver (and not on arduino side) and thus, it should be fine to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.