Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beagleconnect_freedom: Add digital, analog, pwm pins #94

Merged
merged 1 commit into from
May 18, 2024

Conversation

Ayush1325
Copy link
Member

@Ayush1325
Copy link
Member Author

Cc: @jadonk

@DhruvaG2000 DhruvaG2000 self-requested a review May 14, 2024 17:10
Copy link
Collaborator

@DhruvaG2000 DhruvaG2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ayush1325 The commit message feels inadequate to me:

You need to add reasoning as to why it was chosen the way it is. Is there any pinout or diagram somewhere that can justify this mapping?

@DhruvaG2000
Copy link
Collaborator

My main concern here is a person comin new to the platform should be able to quickly make sense of what pin mapping you've created

@jadonk
Copy link

jadonk commented May 14, 2024

Thanks. Looks good to me. Do you have a test procedure?

@Ayush1325
Copy link
Member Author

Thanks. Looks good to me. Do you have a test procedure?

Can you provide some clarification regarding how the pin numbering was chosen. Analog numbering seems simple but not sure about digital pin order.

@jadonk
Copy link

jadonk commented May 15, 2024

Thanks. Looks good to me. Do you have a test procedure?

Can you provide some clarification regarding how the pin numbering was chosen. Analog numbering seems simple but not sure about digital pin order.

Sure.

I looked around for some examples of Arduino Click Shields such that Arduino examples that used mikroBUS boards might "just work", but I found that there wasn't much consistency between the Shields. I chose what I thought was both reasonably popular, affordable and included a reasonably good set of pins and documentation.

I went with MikroE Arduino MKR Click Shield

image

image

I tried to match up the equivalent Arduino pin with the pins on the 2 mikroBUS ports on BeagleConnect Freedom. My thinking was that if it worked on an Arduino MKR with the MikroE Arudino MKR Click Shield, then it should work with BeagleConnect Freedom. That should provide a great test resource.

Can you add this information to the documentation in a reasonable way?

Add pin layout described here:
https://openbeagle.org/beagleconnect/zephyr/arduino-core/-/commit/1ce0b0bfca16ffc9eb781f263525347e0b42cef5

The pin layout is based on MikroE Arduino MKR Click Shield.

MikroE Arduino MKR Click Shield: https://www.mikroe.com/arduino-mkr-click-shield

Signed-off-by: Jason Kridner <jkridner@beagleboard.org>
Signed-off-by: Ayush Singh <ayushdevel1325@gmail.com>
@Ayush1325
Copy link
Member Author

Ayush1325 commented May 18, 2024

@jadonk Thanks for the input. I do not think there is any board specific docs in this repo currently, but we can certainly add a section in our own docs regarding this.

@DhruvaG2000 I think this provides the context for the pin layout?

Copy link
Collaborator

@DhruvaG2000 DhruvaG2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks good now.

@DhruvaG2000 DhruvaG2000 merged commit 0197a8b into zephyrproject-rtos:next May 18, 2024
2 checks passed
@Ayush1325 Ayush1325 deleted the bcf-2 branch May 18, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants