Add EEPROM library #126
Draft
Add EEPROM library #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DhruvaG2000
requested changes
Jan 29, 2025
| namespace arduino { | ||
|
|
||
| class ZephyrEEPROM { | ||
| public: |
There was a problem hiding this comment.
Is the indent correct? Doesn't public need some indentation?
There was a problem hiding this comment.
Both styles work the same in C++, but typically, access specifiers like public are aligned with the class definition. However, the content under access specifiers should have half-indentation for better consistency, I'll make changes. I also referred to the Wire library codebase.
samples/eeprom_operations/README.rst
Outdated
| Overview | ||
| ******** | ||
|
|
||
| A sample that reads data from flash memory, as well as writes data to flash memory. |
There was a problem hiding this comment.
Some sort of sample output will be good to show.
Also a build command to show how to build this sample can make things much easier for any new users
There was a problem hiding this comment.
Yes sure, I'll add a sample output and include a build command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #88
Description:
Implement EEPROM library to ensure compatibility with standard AVR Arduino where actual EEPROM is not present, utilizing non-volatile storage (NVS) as a substitute.
Changes Made:
- Initialization Function: Sets up the NVS storage for data persistence.
- Write Function: Allows writing data into NVS memory.
- Read Function: Retrieves data from NVS memory.
Testing:
Used the beagleconnect_freedom board to test the implementation.
Followed the testing process as outlined here.
Output:
Encountered the following error during testing: unable to get page info.
Please review the code and suggest if any changes are required to improve the implementation or resolve the encountered issue.