Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SPI Library #103

Merged
merged 4 commits into from
Jun 26, 2024
Merged

Add SPI Library #103

merged 4 commits into from
Jun 26, 2024

Conversation

Ayush1325
Copy link
Member

  • Tested master mode on beagleconnect freedom.
  • Add master sample.
  • Interrupts not implemented. Slave mode not tested.
  • Fixes Implementing SPI library #87

DhruvaG2000
DhruvaG2000 requested changes Jun 13, 2024
View reviewed changes
libraries/SPI/SPI.cpp Outdated Show resolved Hide resolved
libraries/SPI/SPI.cpp Outdated Show resolved Hide resolved
libraries/SPI/SPI.cpp Show resolved Hide resolved
samples/spi_master/README.rst Outdated Show resolved Hide resolved
samples/spi_master/src/app.cpp Outdated Show resolved Hide resolved
@Ayush1325 Ayush1325 force-pushed the spi branch 4 times, most recently from 224b248 to 1a0cbdb Compare June 13, 2024 10:16
@DhruvaG2000 DhruvaG2000 requested a review from soburi June 13, 2024 11:23
@Ayush1325 Ayush1325 force-pushed the spi branch 3 times, most recently from f680b98 to 7b3c1fe Compare June 14, 2024 19:24
@Ayush1325 Ayush1325 mentioned this pull request Jun 18, 2024
Closed
Ayush1325 added 4 commits June 19, 2024 21:39
@Ayush1325
libraries: SPI: Initial SPI implementation
f6874dc 
- Tested controller mode on beagleconnect_freedom

Signed-off-by: Ayush Singh <ayush@beagleboard.org>
@Ayush1325
Interrupt support
7b25c31 
- Disable registered interrupts on beginTransaction and re-enable on
  endTransaction.
- Add zephyrInternal.h for APIs not meant for external consumption

Signed-off-by: Ayush Singh <ayush@beagleboard.org>
@Ayush1325
beagleconnect_freedom: Add SPI support
86d2583 
- Only supports master mode

Signed-off-by: Ayush Singh <ayushdevel1325@gmail.com>
@Ayush1325
samples: Add spi master sample
63d6bbb 
- Simple sample that sends bytes to SPI slave
- Tested on beagleconnect freedom

Signed-off-by: Ayush Singh <ayushdevel1325@gmail.com>
DhruvaG2000
DhruvaG2000 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@DhruvaG2000 DhruvaG2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll also have to add the spi node to add support for other platforms as well, but I don't suppose you'd have the hw to test it all anyway.
So I am good with this PR, thanks for addressing all concerns!

@DhruvaG2000 DhruvaG2000 merged commit 73ba170 into zephyrproject-rtos:next Jun 26, 2024
2 checks passed
@Ayush1325 Ayush1325 deleted the spi branch June 26, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DhruvaG2000 DhruvaG2000 DhruvaG2000 approved these changes

@soburi soburi Awaiting requested review from soburi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implementing SPI library
2 participants
@Ayush1325 @DhruvaG2000