Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better MDM target artifact updates & DDM retries #1119

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

np5
Copy link
Member

@np5 np5 commented Feb 8, 2025

No description provided.

@coveralls
Copy link

coveralls commented Feb 8, 2025

Pull Request Test Coverage Report for Build 13377185111

Details

  • 129 of 134 (96.27%) changed or added relevant lines in 11 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 81.402%

Changes Missing Coverage Covered Lines Changed/Added Lines %
zentral/contrib/mdm/artifacts.py 49 50 98.0%
zentral/contrib/mdm/declarations/status_report.py 12 13 92.31%
zentral/contrib/mdm/events/artifacts.py 28 31 90.32%
Totals Coverage Status
Change from base Build 13377160456: 0.02%
Covered Lines: 39634
Relevant Lines: 48689

💛 - Coveralls

@np5 np5 force-pushed the 20250208_better_target_artifact_updates branch 5 times, most recently from c5e1a1a to 173d076 Compare February 11, 2025 10:06
Add retry count in ServerToken for DDM. This should remediate the
network issues on some downloads.

Update all target artifacts in one SQL query. Emit change events for the
target artifacts.

DDM decl. valid == unknown => AwaitingConfirmation, do not bump the retry
count in that case.
@np5 np5 force-pushed the 20250208_better_target_artifact_updates branch from f0d415b to 0a88fba Compare February 17, 2025 19:14
Copy link
Collaborator

@headmin headmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@np5 np5 merged commit 0a88fba into main Feb 17, 2025
10 checks passed
@np5 np5 deleted the 20250208_better_target_artifact_updates branch February 17, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants