refactor: extract reset:migration tests in another testsuite #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
force-pushed
the
refactor/remove-migrate-test-permutation
branch
11 times, most recently
from
9a26a24
to
3257095
Compare
nikophil
commented
Sep 3, 2024
Comment on lines
+146
to
+152
| exclude: | ||
| - database: sqlite | ||
| use-dama: 0 |
There was a problem hiding this comment.
there is a problem with migrate + sqlite + "no dama" :
because we're calling dropAndResetDatabase() which does not actually drop the database for sqlite:
https://github.com/zenstruck/foundry/blob/2.x/src/ORM/AbstractORMPersistenceStrategy.php#L126-L129
I'm wondering if we should not remove the actual file sqlite.db here, but I'm not sure we can access it easily 🤔
WDYT @kbond ?
nikophil
force-pushed
the
refactor/remove-migrate-test-permutation
branch
4 times, most recently
from
7f9cd1e
to
4f970e6
Compare
nikophil
force-pushed
the
refactor/remove-migrate-test-permutation
branch
from
4f970e6
to
e424193
Compare
nikophil
commented
Sep 5, 2024
Comment on lines
+153
to
+154
| - database: mysql | ||
| with-migration-configuration-file: 'tests/Fixture/MigrationTests/configs/migration-configuration-transactional.php' |
There was a problem hiding this comment.
I also discovered that for an obscure reason, transactional mode + MySQL is buggy - at least in our tests, I'm not using MySQL currently in my day-to-day job, so I can live with this. If a user comes with a problem around it, I'll dig a little bit more!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experiment, in order to take "reset: migrate" permutation in another testsuite
(by the way, this fixes #694)