Correct typevars for DictionaryType, MapType, RunEncodedType #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonas Dedden <university@jonas-dedden.de>
jonded94
force-pushed
the
correct-key-value-type-vars
branch
from
f018506 to
6658785
Compare
|
Thank you for these improvements |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dictionaryindex types only can be integer, values types can only be simple typespyarrow-stubs, all primitives are allowed as index typesmapkey and value types can be everything (as far as I was able to see, even tuples are allowed as keys)pyarrow-stubs, only primitives are allowed as key and value types. This makes nested maps impossible.RunEncodedTypelength type can be only signed integers, value types can only be simple typespyarrow-stubs, but I made it a little bit clearer neverthelessLet me know what you think!