Fix Rikiddo migration #1363
Merged
Fix Rikiddo migration #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1363 +/- ##
=======================================
Coverage ? 93.21%
=======================================
Files ? 132
Lines ? 29360
Branches ? 0
=======================================
Hits ? 27368
Misses ? 1992
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Chralt98
approved these changes
Aug 30, 2024
Chralt98
added
s:accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
The pallet prefix for zrml-rikiddo was specified incorrectly in the migration which clears the pallet. This is now mitigated. You can see that clearing the rikiddo pallet now actually deletes a key. That key is for the storage version of the pallet.
It may seem strange that the pallet for custom assets, for instance, doesn't have any keys. This seems to be due to the very different ways these two pallets were initialized, with the
CustomAssetsinstance falling victim to the substrate bug that doesn't set the storage version when a pallet is added to a live chain. You can test this by finding what the storage key for the storage version ofCustomAssetsis (0x97ca552d2b66546c8271d80839408bfd4e7b9012096b41c4eb3aaf947f6ea429) and then querying it on Battery Station or Zeitgeist. The result is0x, i.e. there is no storage under this key. By contrast, the storage key for the storage version of the Rikiddo pallet returns0x0000, the correct zero-initialized value.What important points should reviewers know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues?
References