-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic CMS based market metadata #2020
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…s, TODO: need more imaged pr category
import { getCmsMarketMetadataForMarket } from "lib/cms/get-market-metadata"; | ||
import { NextApiRequest, NextApiResponse, PageConfig } from "next"; | ||
|
||
export const config: PageConfig = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you verify that this works? I think the function signature is a little different for edge: https://vercel.com/docs/functions/edge-functions/edge-functions-api#edge-functions-signature
Would also be good to change the other serverless function in this pr too, probably that one is more important too
lib/cms/sanity/index.ts
Outdated
@@ -0,0 +1,14 @@ | |||
import { createClient, type ClientConfig } from "@sanity/client"; | |||
|
|||
const PROJECT_ID = "4wbnjof1"; // TODO: move to env |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be done?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be in env on latest commit, but its pretty static, didnt change when I migrated the project over to another org.
Fixes #2006
Fixes #2005
Fixes #1452
Fixes #2006