Dynamic CMS based market metadata #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…s, TODO: need more imaged pr category
yornaath
added
review needed
and removed
work in progress
Robiquet
reviewed
Dec 20, 2023
| import { getCmsMarketMetadataForMarket } from "lib/cms/get-market-metadata"; | ||
| import { NextApiRequest, NextApiResponse, PageConfig } from "next"; | ||
|
|
||
| export const config: PageConfig = { |
There was a problem hiding this comment.
Did you verify that this works? I think the function signature is a little different for edge: https://vercel.com/docs/functions/edge-functions/edge-functions-api#edge-functions-signature
Would also be good to change the other serverless function in this pr too, probably that one is more important too
Robiquet
reviewed
Jan 9, 2024
lib/cms/sanity/index.ts
Outdated
| @@ -0,0 +1,14 @@ | |||
| import { createClient, type ClientConfig } from "@sanity/client"; | |||
|
|
|||
| const PROJECT_ID = "4wbnjof1"; // TODO: move to env | |||
There was a problem hiding this comment.
Should be in env on latest commit, but its pretty static, didnt change when I migrated the project over to another org.
Robiquet
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2006
Fixes #2005
Fixes #1452
Fixes #2006