image_viewer: Add ability to zoom and pan images #24547
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces a new capability to the image viewer crate — zoom and pan actions on images in Zed by tapping into a couple of mouse events exposed by GPUI
cla-bot
bot
added
the
cla-signed
kaf-lamed-beyt
changed the title
maxdeviant
changed the title
|
@kaf-lamed-beyt : |
|
Huh. Okay, I'll take a look at the recording and let you know if I have any questions. |
|
@Angelk90, from the video, most of the capabilities there will be included in Zed's image viewer when this is merged. One thing that I am not certain of is the removal of the checkered background. In your video, it is called "remove chessboard". I know how well this sits with the Zed team. So I don't exactly have a say on that. |
|
Thank you for the PR, but we're not moving forward with this feature at this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces zoom and pan actions on images in the image viewer
Closes #9584
Release Notes: