Add character limits to edit prediction prompt generation #23814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
mgsloan
force-pushed
the
prompt-character-limits
branch
2 times, most recently
from
b59e21e to
bad3fa5
Compare
Co-authored-by: Richard <richard@zed.dev> Co-authored-by: Joao <joao@zed.dev>
mgsloan
force-pushed
the
prompt-character-limits
branch
from
bad3fa5 to
e7b9d70
Compare
mgsloan
added a commit
that referenced
this pull request
Jan 30, 2025
mgsloan
added a commit
that referenced
this pull request
Jan 30, 2025
Happily this could be done by copy-modifying some of the code from #23814
mgsloan
added a commit
that referenced
this pull request
Jan 30, 2025
Happily this could be done by copy-modifying some of the code from #23814
mgsloan
added a commit
that referenced
this pull request
Jan 30, 2025
Realized that the logic in #23814 was more than needed, and harder to maintain. Something like that could make sense if using the tokenizer and wanting to precisely hit a token limit. However in the case of edit predictions it's more of a latency+expense vs capability tradeoff, and so such precision is unnecessary. Happily this change didn't require much extra work, just copy-modifying parts of that change was sufficient. Release Notes: - N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limits the size of the buffer excerpt and the size of change history.
Release Notes: