gpui: Enable MSAA to Path render for Anti-Aliasing #22812
Merged
+136
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
huacnlee
commented
Jan 8, 2025
huacnlee
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
huacnlee
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
…th 4 points." This reverts commit 693258f.
This comment was marked as resolved.
This comment was marked as resolved.
kvark
pushed a commit
to kvark/blade
that referenced
this pull request
Jan 10, 2025
There need a method to check if the system supports a specific sample count. Ref zed-industries/zed#22812 need this feature to setup sample_count.
kvark
reviewed
Jan 11, 2025
|
Wait #22808 to merge, then the painting example will be ok: 
|
SomeoneToIgnore
approved these changes
Jan 28, 2025
|
@huacnlee can we merge/rebase on fresh main please? |
|
😂 I don't have a computer right now, I'm on holiday for the Chinese New Year. |
|
No rush, we can get back to that later, and sorry for the pings. Happy holidays! |
SomeoneToIgnore
pushed a commit
that referenced
this pull request
Jan 29, 2025
Release Notes: - N/A --- Continue #20499 We to draw more complex Path. Before this change, we only have `line_to`, but it is not enough. Add a new `PathBuilder` to use [lyon](https://github.com/nical/lyon) to build more complex path. And then with PR #22812 to enable anti-aliasing, all thing will be perfect. ## Show case ```bash cargo run -p gpui --example painting ``` Before: <img width="1136" alt="image" src="https://github.com/user-attachments/assets/0c15833a-ec95-404c-a469-24cf172cfd86" /> After: <img width="1136" alt="image" src="https://github.com/user-attachments/assets/42cfa35e-7e8f-4ef3-bb2d-b98defc62ad6" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20762
Release Notes:
Enable MSAA for Anti-Aliasing to Path (
cx.paint_path) for drawing a better vector graphics.Before
After
TODO
PathBuilderbased on lyon to buildPath#22808 to merge.Ref kvark/blade#213
Ask @kvark to review.
I am not sure if there is anything I missed. I modified it according to the particle example of Blade project. But the difference is that after the first MSAA render, I did not do it a second time, I tested it and found it was not necessary.