Improve rust syntax highlighting. #24361
Replies: 4 comments
-
some additional examples zed![]() VSCode![]() |
Beta Was this translation helpful? Give feedback.
-
Is this still a global issue or is it just my zed? It seems like the syntax highlight lacks a bit, a lot of things share the same colour, especially when compared to neovim. Thank you for the amazing effort everyone. |
Beta Was this translation helpful? Give feedback.
-
@iamnbutler What are your thoughts on coloring lifetimes in our themes? It would indeed be nice to make them stand out a bit more like the examples people are showing. |
Beta Was this translation helpful? Give feedback.
-
I really, really like having type arguments/lifetimes both colorized and italicized. NeovimZedIt would be awesome to reuse my existing tree-sitter queries to merge/override zed's queries and just tweak the colors associated with the matches. Colors that differentiate between primitive types and type identifiers would also be great. The lack of a user-facing, fine-grained customization for syntax highlighting is less than ideal. That said, it seems like zed is close to super-customizable and the vim integration probably the best outside of vim/neovim. |
Beta Was this translation helpful? Give feedback.
-
Check for existing issues
Describe the feature
Some improvement points I found of zed rust syntax highlighting are below.
lifetime
Color rust lifetime.
Zed ⬇️
![Snipaste_2024-02-12_12-14-01](https://private-user-images.githubusercontent.com/39210593/303970303-c6f4ef86-82b5-48b8-a11d-93ae0b256ad9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4NjE3MjYsIm5iZiI6MTczODg2MTQyNiwicGF0aCI6Ii8zOTIxMDU5My8zMDM5NzAzMDMtYzZmNGVmODYtODJiNS00OGI4LWExMWQtOTNhZTBiMjU2YWQ5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA2VDE3MDM0NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE0NjQwZjZmNTQzMDM4YjRkODE1NWNhMTA3YWEzMjZmNWI5OTU5YzkwNTdjOTMwZTY2ZGY3MzkzZjFjNTU0YTUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.652hoKrzjb5EnQeyMZh9UQvLIZVj97Jkj9kGFaiKZFI)
RustRover (Expected) ⬇️
![Snipaste_2024-02-12_12-30-06](https://private-user-images.githubusercontent.com/39210593/303971124-fff82882-01df-49a0-a4ca-d3f37db32aa2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4NjE3MjYsIm5iZiI6MTczODg2MTQyNiwicGF0aCI6Ii8zOTIxMDU5My8zMDM5NzExMjQtZmZmODI4ODItMDFkZi00OWEwLWE0Y2EtZDNmMzdkYjMyYWEyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA2VDE3MDM0NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM1MzY1ODFiMjU2MDcxYTgyNDY2OTRkNzM2MjE1MmFlYTk2MmRjODUxZDhmZmU2MDEyYTU2OGQyOGM3Y2FlODgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.KBB5fZ0P3abVIBCxwBOFLcXOvj-PA0l40NDarw1Whuo)
![Snipaste_2024-02-12_12-36-37](https://private-user-images.githubusercontent.com/39210593/303971575-a7d81c29-8914-4479-96c1-268fe533cf29.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4NjE3MjYsIm5iZiI6MTczODg2MTQyNiwicGF0aCI6Ii8zOTIxMDU5My8zMDM5NzE1NzUtYTdkODFjMjktODkxNC00NDc5LTk2YzEtMjY4ZmU1MzNjZjI5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA2VDE3MDM0NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM5MGZhMjExMWFkNjU2OWYwMDE4YjZmMzNiYzViZjNlZWRiMDdmNTg0MWNmNWY1OTZkMmQ0OWNmM2Q1MDc4ZTImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.2ZpMRC_2aCHlMbjM1kTebbZ1JfSFP41dQbsiATxtiSM)
generic
Color generic with a separate color. (now it's same as "type")
![Snipaste_2024-02-12_12-29-20](https://private-user-images.githubusercontent.com/39210593/303972207-6cb78339-26f3-4052-a03f-3ac1aae9abc9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4NjE3MjYsIm5iZiI6MTczODg2MTQyNiwicGF0aCI6Ii8zOTIxMDU5My8zMDM5NzIyMDctNmNiNzgzMzktMjZmMy00MDUyLWEwM2YtM2FjMWFhZTlhYmM5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA2VDE3MDM0NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTcwYzM2OTk3MDQ3NTg5MDUwZWQyY2RiMjk5N2JjNzE1MzllZTJiMTZiYjhhODcyNDc0N2M1ZWRiMWExYmU3YWQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.kucIqqCiFKMUsKkm2rV6v8-yTOxyf_wu5MbxOzrfjFE)
![Snipaste_2024-02-12_12-28-25](https://private-user-images.githubusercontent.com/39210593/303972261-4ed975a8-a2c0-4f84-bc09-0f1956833094.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4NjE3MjYsIm5iZiI6MTczODg2MTQyNiwicGF0aCI6Ii8zOTIxMDU5My8zMDM5NzIyNjEtNGVkOTc1YTgtYTJjMC00Zjg0LWJjMDktMGYxOTU2ODMzMDk0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA2VDE3MDM0NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNjZjg1MTdlMWRjOTJkYTI4M2ZmNmM3NGFjODAxODAzM2RjMTU1ZGU2ZTYxZWU4OGViMTlhZWE2MTc4MGExMzgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.kTDhwAjLBKISzb4ni7SL5E7XHBfEyTvaMVGZYJFneYY)
Zed ⬇️
RustRover (Expected) ⬇️
proc macro
Color proc macros with a separate color. (Now it's same as "editor.foreground")
![Snipaste_2024-02-12_12-14-20](https://private-user-images.githubusercontent.com/39210593/303970261-5cd008b7-89b8-4b22-b136-5fb11db6189f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4NjE3MjYsIm5iZiI6MTczODg2MTQyNiwicGF0aCI6Ii8zOTIxMDU5My8zMDM5NzAyNjEtNWNkMDA4YjctODliOC00YjIyLWIxMzYtNWZiMTFkYjYxODlmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA2VDE3MDM0NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTk3ZmE3MTkwY2RkMzU3Njg3ZGUxYzAyMWJlZTU4N2JlODkzMDIyYzA5ZDA4YzU0MDE0YjEyNzgzOWE0MzEyYTgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.bpUq_SVKivcmoHkHHKHZbO7Kc7Glf4lGDsELL56DrMQ)
![Snipaste_2024-02-12_12-14-43](https://private-user-images.githubusercontent.com/39210593/303970271-fb4d59c0-e91e-4dfd-b956-d3a4d36f9a4f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4NjE3MjYsIm5iZiI6MTczODg2MTQyNiwicGF0aCI6Ii8zOTIxMDU5My8zMDM5NzAyNzEtZmI0ZDU5YzAtZTkxZS00ZGZkLWI5NTYtZDNhNGQzNmY5YTRmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA2VDE3MDM0NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThlMDUxMGVlNzdlODIwODVlNjc1MjFlN2Q1ZDU4NzkyYjIyMzczMmUxMTk4N2UzYWY1MjlmMGQ1ODgwYzhmNmImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.IozMR-g9TVrRUJWvccSCr9karLOt2tn9TB-x2GfyCZE)
Zed ⬇️
RustRover (Expected) ⬇️
![Snipaste_2024-02-12_12-32-57](https://private-user-images.githubusercontent.com/39210593/303971312-f8460372-efcd-4481-a1a7-fa393e114d94.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4NjE3MjYsIm5iZiI6MTczODg2MTQyNiwicGF0aCI6Ii8zOTIxMDU5My8zMDM5NzEzMTItZjg0NjAzNzItZWZjZC00NDgxLWExYTctZmEzOTNlMTE0ZDk0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA2VDE3MDM0NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRkNzNmMmNkN2FhZGJiYjY5ODZkOTYzZjBmYWRmYTRkOGEyOWFiOWIzMWUxMTE1ZTQyNDZhMmEzM2ZkODljMDkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.wN-0bAF4hvBcg0Z3hBWZbIBvQJ65bmktaKaTVF68jxA)
![Snipaste_2024-02-12_12-33-04](https://private-user-images.githubusercontent.com/39210593/303971316-b0acb701-eba1-4a00-8a2d-5da452a3520d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4NjE3MjYsIm5iZiI6MTczODg2MTQyNiwicGF0aCI6Ii8zOTIxMDU5My8zMDM5NzEzMTYtYjBhY2I3MDEtZWJhMS00YTAwLThhMmQtNWRhNDUyYTM1MjBkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA2VDE3MDM0NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTViMzI5NzU0ZDVmYzkwZjE3ZDEzMjE0YmMyOTMzZjFiZGU2MGRlMjVlMzUxNGZkOTE3MWZmZDAxYTAwNjI5N2YmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.bgx9eqfe4o6tNILa842mrcuqPY1wJ_rj5xFRsbz9gt4)
macro's name
Recognize macro name's ! as a whole. (I don't know if this is intentional)
Zed ⬇️
![Snipaste_2024-02-12_12-15-24](https://private-user-images.githubusercontent.com/39210593/303970233-b1d93531-94a7-4813-a0f7-70ab7eae92cc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4NjE3MjYsIm5iZiI6MTczODg2MTQyNiwicGF0aCI6Ii8zOTIxMDU5My8zMDM5NzAyMzMtYjFkOTM1MzEtOTRhNy00ODEzLWEwZjctNzBhYjdlYWU5MmNjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA2VDE3MDM0NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE4OTk2ZWFkOTZkM2Q4ZWIzMzQ5OTMyYzRkMmY1MzkxYzZkZjc0MWM5NmU3ZWYzYzE3NGY0MjgwYjE0NjAxZmImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.F2EOfVnLAQSZadyWloHIvHCBbT4Ipeirki-D_M5WubQ)
If applicable, add mockups / screenshots to help present your vision of the feature
No response
Beta Was this translation helpful? Give feedback.
All reactions