Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
editor: Fix inline Git blame not visible on long lines due to overflow (
#23374) Closes #18702 This is take 2 of [my previous PR](#19555), which was closed due to inactivity and merge conflicts. **Cause**: The editor's horizontal scroll width only considers the longest line in the buffer, using `layout_line` for `longest_row`. The inline blame width isn’t included in it because it is just a decoration on top of the line (think of like CSS absolute) and not part of its actual content. This causes blame to overflow. **Solution**: Along with `longest_row` width we also add that line's inline blame width for scroll width calculation. We also have to add some padding that is between inline blame and line's content. **Alternate Solution**: In my previous PR, instead of adding the inline blame width of the longest line for scroll width calculation, I used the inline blame of the current line the cursor is on (since we only see the blame for the current line). I added that to the current line's width, giving us the full width of that row. Then, we compare that row's width with the longest row width and use the max of the two for the scroll width calculation. While this solution seems clever, it's overly complicated and could cause issues, like the scroll width changing every time you move the cursor up or down. I don't think we should go with this, but I'm open to suggestions. **Preview**: Before: https://github.com/user-attachments/assets/01ef90cf-06e7-4ebb-8bd1-637a53e0654e After: https://github.com/user-attachments/assets/b13616de-bdea-4da4-b32d-9c4104448166 Release Notes: - Fixed inline Git blame not visible on long lines due to overflow.
- Loading branch information