Clean up warning filters in tests #2714
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
force-pushed
the
catch-warnings
branch
8 times, most recently
from
596d674 to
d157e9c
Compare
github-actions
bot
added
the
needs release notes
dstansby
force-pushed
the
catch-warnings
branch
2 times, most recently
from
d6d8c91 to
2b91d6e
Compare
dstansby
force-pushed
the
catch-warnings
branch
from
2b91d6e to
4bb6318
Compare
github-actions
bot
removed
the
needs release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm hoping to clean up the warning filters in this PR, starting with making them all error, and then either fix the warnings that come up or add them back to the filters. Opening because I noticed some deprecation warnings in our tests that should probably either be explicitly caught or the code fixed.
Opening as draft for now, will take out of draft status when this is good to go.