Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pscanrules: Refactor CookieLooselyScopedScanRule to align with the latest RFC standards #6216

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

pscanrules: Refactor CookieLooselyScopedScanRule to align with the latest RFC standards #6216

wants to merge 5 commits into from

Conversation

uncavo-hdmi
Copy link

@uncavo-hdmi uncavo-hdmi commented Feb 23, 2025 •
edited by thc202
Loading

This PR addresses the issue reported in the zaproxy project (CookieLooselyScoped scan rule Incorrect logic and outdated RFC standard #8863)

Fix zaproxy/zaproxy#8863.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 23, 2025 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@uncavo-hdmi
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@thc202 thc202 changed the title Refactor CookieLooselyScopedScanRule to align with the latest RFC standards pscanrules: Refactor CookieLooselyScopedScanRule to align with the latest RFC standards Feb 23, 2025
@psiinon
Copy link
Member

psiinon commented Feb 23, 2025 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 2acd18c6-ae10-4b8a-95b6-5d77e8e5a207

Great job, no security vulnerabilities found in this Pull Request

kingthorin
kingthorin reviewed Feb 23, 2025
View reviewed changes
Copy link
Member

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CHANGELOG.md should also be updated. The help may need to be tweaked as well.

kingthorin
kingthorin reviewed Feb 23, 2025
View reviewed changes
Copy link
Member

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one minor item for the changelog.

kingthorin
kingthorin approved these changes Feb 23, 2025
View reviewed changes
Copy link
Member

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@uncavo-hdmi uncavo-hdmi requested a review from thc202 February 25, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingthorin kingthorin kingthorin approved these changes

@thc202 thc202 Awaiting requested review from thc202

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CookieLooselyScoped scan rule Incorrect logic and outdated RFC standard
4 participants
@uncavo-hdmi @psiinon @thc202 @kingthorin