Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commonlib: Output panel indicator updates #6215

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ricekot
Copy link
Member

@ricekot ricekot commented Feb 22, 2025

Overview

  • Show the unread indicator on the main output panel as well. The indicator goes away when all tabs (including detached ones) are read.
  • Mark tab as read if the mouse enters the toolbar region. Earlier, it was possible to clear a panel using the broom button while it was still marked unread. This behaviour is fixed now.
  • Reduce the size of the green-badge-corner.png image by removing unnecessary metadata or attributes from it (creation time, resolution, and background color).
  • Rename "outputPanel" variables to "outputTab" for clarity.

Related Issues

Follow up to #6198.

Checklist

  • Update help
  • Update changelog
  • Run ./gradlew spotlessApply for code formatting
  • Write tests
  • Check code coverage
  • Sign-off commits
  • Squash commits
  • Use a descriptive title

- Show the unread indicator on the main output panel as well. The indicator
  goes away when all tabs (including detached ones) are read.
- Mark tab as read if the mouse enters the toolbar region. Earlier, it was
  possible to clear a panel using the broom button while it was still marked
unread. This behaviour is fixed now.
- Reduce the size of the green-badge-corner.png image by removing unnecessary
  metadata or attributes from it (creation time, resolution, and background
color).
- Rename "outputPanel" variables to "outputTab" for clarity.

Signed-off-by: ricekot <git@ricekot.com>
@psiinon
Copy link
Member

psiinon commented Feb 22, 2025

Logo
Checkmarx One – Scan Summary & Detailsc40c90a5-57e1-4e07-b3e1-2e1d294bc622

Great job, no security vulnerabilities found in this Pull Request

Copy link
Member

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not for this PR but what do you think of a per tab option to ignore updates?

@ricekot
Copy link
Member Author

ricekot commented Feb 22, 2025

what do you think of a per tab option to ignore updates?

Do you mean an option to:

  1. not show the indicator for some tabs, or
  2. not append any messages to them?

Any specific use-case you are thinking of for this option?

On a side note I've been thinking about the pros / cons of exposing options to the user vs making the decision for them (especially for UI related things). Adding more options gives more choice to the user, but it could also make the tool feel more overwhelming.

@kingthorin
Copy link
Member

kingthorin commented Feb 22, 2025

I was thinking point 1.

I'm just considering that while output for errors etc might be helpful there may be situations where users don't need to know about every update to the tab.

Ex: the current just general output tab, I hardly ever look at unless I'm after something specific.

I dunno, you're right there definitely is a balance between configurability and complexity.

I'm only one voice, we could wait and see if anyone else brings it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants