From 6e4a9d746f3db865d6b448df8ebc5d1025cf158e Mon Sep 17 00:00:00 2001
From: kingthorin <kingthorin@users.noreply.github.com>
Date: Wed, 5 Feb 2025 11:44:33 -0500
Subject: [PATCH] scripts: Correct field name when -autogenconf is used

- CHANGELOG > Added fix note.
- ScriptJob > Remove unnecessary constant and overridden
getCustomConfigParameters method.

Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
---
 addOns/scripts/CHANGELOG.md                              | 3 ++-
 .../zap/extension/scripts/automation/ScriptJob.java      | 9 ---------
 2 files changed, 2 insertions(+), 10 deletions(-)

diff --git a/addOns/scripts/CHANGELOG.md b/addOns/scripts/CHANGELOG.md
index 4b2acc348a1..5f6e8ce245f 100644
--- a/addOns/scripts/CHANGELOG.md
+++ b/addOns/scripts/CHANGELOG.md
@@ -4,7 +4,8 @@ All notable changes to this add-on will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 ## Unreleased
-
+### Fixed
+- Corrected the field name written to the file when -autogenconf is used.
 
 ## [45.8.0] - 2025-01-10
 ### Added
diff --git a/addOns/scripts/src/main/java/org/zaproxy/zap/extension/scripts/automation/ScriptJob.java b/addOns/scripts/src/main/java/org/zaproxy/zap/extension/scripts/automation/ScriptJob.java
index c6c912cc505..ef143443453 100644
--- a/addOns/scripts/src/main/java/org/zaproxy/zap/extension/scripts/automation/ScriptJob.java
+++ b/addOns/scripts/src/main/java/org/zaproxy/zap/extension/scripts/automation/ScriptJob.java
@@ -45,7 +45,6 @@ public class ScriptJob extends AutomationJob {
 
     public static final String JOB_NAME = "script";
     public static final String PARAM_ACTION = "action";
-    public static final String PARAM_SCRIPT_NAME = "scriptName";
     protected static final Map<String, Function<ScriptJobParameters, ScriptAction>> ACTIONS =
             new HashMap<String, Function<ScriptJobParameters, ScriptAction>>() {
                 private static final long serialVersionUID = 1L;
@@ -146,14 +145,6 @@ public ScriptJobParameters getParameters() {
         return parameters;
     }
 
-    @Override
-    public Map<String, String> getCustomConfigParameters() {
-        Map<String, String> map = super.getCustomConfigParameters();
-        map.put(PARAM_ACTION, "");
-        map.put(PARAM_SCRIPT_NAME, "");
-        return map;
-    }
-
     @Override
     public void showDialog() {
         new ScriptJobDialog(this).setVisible(true);