Skip to content

Commit

Permalink
scripts: Correct field name when -autogenconf is used
Browse files Browse the repository at this point in the history
- CHANGELOG > Added fix note.
- ScriptJob > Remove unnecessary constant and overridden
getCustomConfigParameters method.

Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
  • Loading branch information
kingthorin committed Feb 5, 2025
1 parent 4af5899 commit 6e4a9d7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 10 deletions.
3 changes: 2 additions & 1 deletion addOns/scripts/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ All notable changes to this add-on will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

## Unreleased

### Fixed
- Corrected the field name written to the file when -autogenconf is used.

## [45.8.0] - 2025-01-10
### Added
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ public class ScriptJob extends AutomationJob {

public static final String JOB_NAME = "script";
public static final String PARAM_ACTION = "action";
public static final String PARAM_SCRIPT_NAME = "scriptName";
protected static final Map<String, Function<ScriptJobParameters, ScriptAction>> ACTIONS =
new HashMap<String, Function<ScriptJobParameters, ScriptAction>>() {
private static final long serialVersionUID = 1L;
Expand Down Expand Up @@ -146,14 +145,6 @@ public ScriptJobParameters getParameters() {
return parameters;
}

@Override
public Map<String, String> getCustomConfigParameters() {
Map<String, String> map = super.getCustomConfigParameters();
map.put(PARAM_ACTION, "");
map.put(PARAM_SCRIPT_NAME, "");
return map;
}

@Override
public void showDialog() {
new ScriptJobDialog(this).setVisible(true);
Expand Down

0 comments on commit 6e4a9d7

Please sign in to comment.