Rewriting bunch of stuff #75
Conversation
…nd allow clicking it like with the DataPointer (plus small thing in json)
…es the game stuff, make Spelunky2 class into Singleton design
This reverts commit 69c7c14.
…ryMappedData" as it was only holding pointer to the configuration and some configuration type functions, don't require valid configuration to load toolbar. Removed parameter from `TreeViewMemoryFields` constructor as it's only used for vtable stuff, need to fix later
…pattern lookups there, some optimisations
…tead of array. A lot of optimisations, changes, fixes to the previous commits
… clicking on hex value only do something for pointers
…ield instead of update, allow std::string as data to avoid conversions to QSrting and back. Add class for quick check for enabled columns (in future: don't updated invisible fields, allow show/hide columns by the user), don't move `MemoryField` struct as QVariant data since there is no need
… throw error if json struct have two fields named the same
| } | ||
| return gSpelunky2AfterBundleSize; | ||
| } | ||
|
|
||
| // size_t S2Plugin::Spelunky2::findEntityListMapOffset() |
There was a problem hiding this comment.
Wait, this commented out code here
auto mapPtr = reinterpret_cast<std::unordered_map<std::string, uint16_t>*>(mapOffset);
dprintf("mapPtr size = %d\n", mapPtr->size());I thought that it's impossible to read game memory without using Script::Memory::Read* functions?
…ory lookups to single file
…st all the file related stuff to Configuration, move MemoryFieldData to .cpp
…tc. are saved when adding a row to it, so then it basically updates itself, try to reduce the amount of code
…emove all the maps with offsets, try to improve stuff as i go
…more LevelGen files, remove unused StdSet MemoryFieldType
| // TODO: would love to instead get the names and save them in addMemoryField and then just use itemValue->setForeground or itemValue->setData(Qt::TextColorRole) for the color | ||
| // but it doesn't work with HTML delagate, and i don't know how to edit it to make it work |
There was a problem hiding this comment.
Would appreciate some help with this, assuming it is possible
…clean up around the strings view etc.
…tion in the comparison
|
Please pause work on this PR. We are going to reorganize the project. It will be moved to my personal account (before this PR), then forked under the spelunkyfyi organisation. You will also get write access to the fork. Let me know when you are ready with your backup. |
|
@zappatic I'm ready |
|
So , I assume I should move this PR to the spelunkyfyi fork now? Are you cutting your involvement completely now? |
|
Well I had assumed the transfer would have wiped out all the PR's, that's why I asked to back everything up so you wouldn't lose your work. Apparently they are moved over, so now you can indeed reapply it to the fork. I think you could either make a patch and reapply, or maybe point your origin on your local fork to the spelunky-fyi fork, not sure what all is possible here, but shouldn't be that hard. It's not necessarily cutting involvement, I just wanted you to have write access to the fork, so you can work on it directly. You are free to implement whatever you see fit of course, I just don't have the time to verify these huge commits. Have fun with it ;) |
Putting PR out to see the changes better, maybe get feedback while working on this
#66