Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add debug flag while starting workflows #454

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SebastianMorawiec
Copy link
Contributor

The problem

WD introduced new debug flag to help debugging issues with starting up/shutting down of workflows

This PR's solution

Add API for users to set that flag

Checklist

Check that this PR satisfies the following items:

  • Tests have been added for new features/changed behavior (if no new features have been added, check the box).
  • The changelog file has been updated with a user-readable description of the changes (if the change isn't visible to the user in any way, check the box).
  • The PR's title is prefixed with <feat/fix/chore/imp[rovement]/int[ernal]/docs>[!]:
  • The PR is linked to a JIRA ticket (if there's no suitable ticket, check the box).

@SebastianMorawiec SebastianMorawiec requested a review from a team October 9, 2024 14:13
Copy link

github-actions bot commented Oct 9, 2024

🚀 Code Coverage

---------------------------------------------------------------------------------------
src/orquestra/workflow_runtime/_ray/_build_workflow.py      258     59    77%   65-66, 70-72, 171-177, 185, 189-190, 223, 308-317, 437-451, 473-479, 492, 563-576, 585-589, 654-665, 696-698, 709-714
src/orquestra/workflow_runtime/_ray/_client.py               90     13    86%   27-33, 57, 172-173, 187-188, 210-211
src/orquestra/workflow_runtime/_ray/_dag.py                 220     22    90%   81, 241, 351-366, 393, 431-432, 539-540, 560-563, 589-591, 666-668, 704-705, 789, 800
src/orquestra/workflow_runtime/_ray/_dirs.py                 24      8    67%   29-32, 37-40
src/orquestra/workflow_runtime/_testing/_connections.py      38      6    84%   34, 43-56, 83-85
---------------------------------------------------------------------------------------
TOTAL                                                       855    108    87%

6 files skipped due to complete coverage.
-------------
Diff Coverage
Diff: origin/main...HEAD, staged and unstaged changes
-------------
projects/orquestra-workflow-runtime/src/orquestra/workflow_runtime/_ray/_dag.py (50.0%): Missing lines 393
-------------
Total:   2 lines
Missing: 1 line
Coverage: 50%
-------------

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants