Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/ci on slab2 #1016

Merged
merged 49 commits into from
Feb 17, 2025
Merged

Feat/ci on slab2 #1016

merged 49 commits into from
Feb 17, 2025

Conversation

andrei-stoian-zama
Copy link
Collaborator

@andrei-stoian-zama andrei-stoian-zama commented Feb 3, 2025

  • Moves the CI to Slab
  • fixes the flaky retry skips coverage check result
  • removes check links in the weekly
  • improves check links to add 5 retries per link
  • adds ARM Mac tests - fixes cpu count bug when n-cpus<4
  • fixes Intel Mac CI warnings (ignore)

Probably breaks the Release CI, to be fixed later

Closes https://github.com/zama-ai/concrete-ml-internal/issues/4709
Closes https://github.com/zama-ai/concrete-ml-internal/issues/4679
Closes https://github.com/zama-ai/concrete-ml-internal/issues/4428
Closes https://github.com/zama-ai/concrete-ml-internal/issues/4010
Closes https://github.com/zama-ai/concrete-ml-internal/issues/3931
Closes https://github.com/zama-ai/concrete-ml-internal/issues/3498

@cla-bot cla-bot bot added the cla-signed label Feb 3, 2025
@andrei-stoian-zama andrei-stoian-zama changed the base branch from main to feat/ci_on_slab February 3, 2025 10:41
kcelia
kcelia previously approved these changes Feb 14, 2025
Copy link
Contributor

@kcelia kcelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Copy link

⚠️ Known flaky tests have been rerun ⚠️

One or several tests initially failed but were identified as known flaky. tests. Therefore, they have been rerun and passed. See below for more details.

Failed tests details

Known flaky tests that initially failed:

  • tests/torch/test_compile_torch.py::test_compile_torch_or_onnx_networks[compile-is_onnx-FHE_simulation-BranchingGemmModule-5-relu]

Copy link

Coverage passed ✅

Coverage details

---------- coverage: platform linux, python 3.8.18-final-0 -----------
Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL    8545      0   100%

63 files skipped due to complete coverage.

@andrei-stoian-zama
Copy link
Collaborator Author

@jfrery, @kcelia , I got the CI time down by reducing the grid sizes in the comparisons notebooks (only when running in the CI).

The run is here: https://github.com/zama-ai/concrete-ml/actions/runs/13346895240 there was a flaky not-marked at flaky failure but other than that everything went fine. Please review

@andrei-stoian-zama andrei-stoian-zama merged commit 64e1524 into main Feb 17, 2025
38 of 40 checks passed
@andrei-stoian-zama andrei-stoian-zama deleted the feat/ci_on_slab2 branch February 17, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants