feat: 新增函数重试方法，自定义重试次数和延迟重试时间 #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bill37chen
force-pushed
the
master
branch
2 times, most recently
from
e818748 to
769eb6a
Compare
Ehco1996
reviewed
Sep 16, 2022
| } | ||
| } | ||
|
|
||
| func Retry(retryFunc RetryFunc, opt ...Option) error { |
There was a problem hiding this comment.
it seems that use a ctx param is more straightforward than use aContext option?
| o(retryConfig) | ||
| } | ||
| for i := uint(0); i < retryConfig.times; i++ { | ||
| err := retryFunc() |
There was a problem hiding this comment.
maybe also add a func shouldRetry(err) to check if this the current scene is ready for retry, not all funcs are idempotent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
接入多平台业务时总会遇到一些需要重试的操作，这个commit实现了简单的函数重试逻辑