fix: issue-717: proper set default value for list variables

zaichengwang · Jan 9, 2024 · a65e53f · a65e53f
1 parent 4fc743b
commit a65e53f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/v2/pkg/astnormalization/inject_input_default_values.go b/v2/pkg/astnormalization/inject_input_default_values.go
@@ -205,6 +205,7 @@ func (v *inputFieldDefaultInjectionVisitor) jsonWalker(fieldType int, defaultVal
 			}
 			if replaced {
 				*finalVal, err = jsonparser.Set(defaultValue, newVal, fmt.Sprintf("[%d]", i))
+				defaultValue = *finalVal
 				if err != nil {
 					return
 				}
@@ -217,6 +218,7 @@ func (v *inputFieldDefaultInjectionVisitor) jsonWalker(fieldType int, defaultVal
 			}
 			if replaced {
 				*finalVal, err = jsonparser.Set(defaultValue, newVal, fmt.Sprintf("[%d]", i))
+				defaultValue = *finalVal
 				if err != nil {
 					return
 				}

diff --git a/v2/pkg/astnormalization/inject_input_default_values_test.go b/v2/pkg/astnormalization/inject_input_default_values_test.go
@@ -241,6 +241,19 @@ func TestInputDefaultValueExtraction(t *testing.T) {
 			}`, `{"a":[{"thirdField":1}]}`, `{"a":[{"thirdField":1,"firstField":"firstField","secondField":1}]}`)
 	})
 
+	t.Run("simple list nested input with more than 2 elements", func(t *testing.T) {
+		runWithVariablesAssert(t, func(walker *astvisitor.Walker) {
+			injectInputFieldDefaults(walker)
+		}, testInputDefaultSchema, `
+			mutation mutationSimpleInputList($a: [SimpleTestInput]) {
+			  mutationSimpleInputList(data: $a)
+			}`, "", `
+			mutation mutationSimpleInputList($a: [SimpleTestInput]) {
+			  mutationSimpleInputList(data: $a)
+		}`, `{"a":[{"thirdField":1}, {"thirdField":2}, {"thirdField":3}]}`,
+			`{"a":[{"thirdField":1,"firstField":"firstField","secondField":1}, {"thirdField":2,"firstField":"firstField","secondField":1}, {"thirdField":3,"firstField":"firstField","secondField":1}]}`)
+	})
+
 	t.Run("use custom scalar variable", func(t *testing.T) {
 		runWithVariablesAssert(t, func(walker *astvisitor.Walker) {
 			injectInputFieldDefaults(walker)