Dev lb maps #117
Closed
Dev lb maps #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add aws amplify module * chore: terraform fmt and terraform-docs * ignore jscpd in the github actions test workflow --------- Co-authored-by: zachreborn <zachreborn@users.noreply.github.com>
* removed the tfsec scan * converting nighly scan from tfsec to checkov
* updated igw args to allow false == 0 count * added new logic for igw * added two new examples for disabling the igw * fixed index of the pointers * corrected variable to enable_internet_gateway * added type to all vpc variables * chore: terraform fmt and terraform-docs --------- Co-authored-by: Jakeasaurus <Jakeasaurus@users.noreply.github.com> Co-authored-by: Zachary Hill <zhill@octo.ventures>
|
Closing. Please reference older PR that has more context. #112 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New LB module that will allow for the following:
NLB and ALB specific resources are created using logic that will use and allow the specific resources that apply to each.
Issue or Ticket
Fixes #110
Type of change
Breaking Changes
Breaking Changes Description
None, should be new functionality not currently in use.
TODOs