-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch sensor data #10
base: main
Are you sure you want to change the base?
Conversation
Hi, I've try this PR but I meet the error as below:
|
@calee0219 Thank you very much for the report. I developed this PR for Nature Remo 3 which has temperature, humidity, illumination, and motion sensors. I guess you test this PR with Nature Remo Mini, which only has a temperature sensor. Is this correct? I will make the change to check for the availability of each sensor instead of just assuming that all sensors are available. |
Yes, the controler is using Nature Remo and Nature Remo Mini both. |
@calee0219 It's a very small change so I haven't really tested the code. Would you please confirm whether the latest commit fixes the issue? |
@puchupala thanks a lot! I have check on my side and there is no error now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR work on my environment.
Add temperature, humidity, and illuminance sensors as 3 new separate entities.
This is my first time playing around with Home Assistant so I'm not sure how efficient my code is.
Most of the code is a direct modification from the Nature Remo E sensor.
Specifically, I'm not sure why we need the following method.
In any case, things seem to work...