Skip to content

Commit

Permalink
[#21329] Style: Don't derive ptr alignment
Browse files Browse the repository at this point in the history
Summary:
We seem to prefer
`const string& foo = "lorem ipsum";`
over
`const string &foo = "lorem ipsum";`

However, in spite of having  `PointerAlignment: Left`

`arcanist_util/pre_commit_hook.sh` sometimes prefers the latter due to  `DerivePointerAlignment: true`

more details here: https://stackoverflow.com/questions/56537847/why-do-the-pointeralignment-options-not-work
Jira: DB-10234

Test Plan:
run
arcanist_util/pre_commit_hook.sh

Reviewers: arybochkin, bogdan, rthallam, dmitry, sergei

Reviewed By: arybochkin

Subscribers: ybase

Differential Revision: https://phorge.dev.yugabyte.com/D32784
  • Loading branch information
amitanandaiyer committed Mar 6, 2024
1 parent 8977a1a commit 972e93c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .clang-format
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ ConstructorInitializerAllOnOneLineOrOnePerLine: true
ConstructorInitializerIndentWidth: 4
ContinuationIndentWidth: 4
Cpp11BracedListStyle: true
DerivePointerAlignment: true
DerivePointerAlignment: false
DisableFormat: false
ExperimentalAutoDetectBinPacking: false
ForEachMacros: [ foreach, Q_FOREACH, BOOST_FOREACH ]
Expand Down

0 comments on commit 972e93c

Please sign in to comment.